Bug 79010

Summary: Attached/Detached state must be testable
Product: WebKit Reporter: Shinya Kawanaka <shinyak>
Component: DOMAssignee: Shinya Kawanaka <shinyak>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, gustavo.noronha, gustavo, shinyak, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Test
none
Test
none
Patch none

Shinya Kawanaka
Reported 2012-02-19 21:45:39 PST
When considering Shadow DOM, light tree won't be rendered but should be attached. The state 'attached' or 'detached' is currently not testable. When implementing Shadow DOM, that state will often become wrong by implementation mistakes. We should have a method to test them in Internals.
Attachments
Test (2.82 KB, patch)
2012-02-19 21:57 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Test (2.73 KB, patch)
2012-02-19 23:05 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch (5.78 KB, patch)
2012-02-20 00:41 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Shinya Kawanaka
Comment 1 2012-02-19 21:57:09 PST
Created attachment 127759 [details] Test
Collabora GTK+ EWS bot
Comment 2 2012-02-19 22:37:10 PST
Comment on attachment 127759 [details] Test Attachment 127759 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11548183
Early Warning System Bot
Comment 3 2012-02-19 22:37:55 PST
Comment on attachment 127759 [details] Test Attachment 127759 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/11551077
WebKit Review Bot
Comment 4 2012-02-19 22:48:36 PST
Comment on attachment 127759 [details] Test Attachment 127759 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11550092
Shinya Kawanaka
Comment 5 2012-02-19 23:05:17 PST
Created attachment 127767 [details] Test
Shinya Kawanaka
Comment 6 2012-02-20 00:41:47 PST
Created attachment 127776 [details] Patch
WebKit Review Bot
Comment 7 2012-02-20 01:33:31 PST
Comment on attachment 127776 [details] Patch Clearing flags on attachment: 127776 Committed r108226: <http://trac.webkit.org/changeset/108226>
WebKit Review Bot
Comment 8 2012-02-20 01:33:35 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.