Bug 79009

Summary: Remove a ReadWriteLock class because it seems not to be used anywhere.
Product: WebKit Reporter: Kwonjin Jeong <gram>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, darin, eric, gram, gyuyoung.kim, hyatt, levin+threading, lforschler, mrowe, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch v.1
none
patch v.2 eric: review+, webkit.review.bot: commit-queue-

Kwonjin Jeong
Reported 2012-02-19 21:22:21 PST
Despite searching all of the WebKit code, I can't find any place using a ReadWriteLock class. It seems to be useless. So, I report a patch that remove the class.
Attachments
patch v.1 (14.77 KB, patch)
2012-02-19 21:40 PST, Kwonjin Jeong 		no flags
DetailsFormatted DiffDiff
patch v.2 (6.62 KB, patch)
2012-02-19 21:58 PST, Kwonjin Jeong 		eric: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kwonjin Jeong
Comment 1 2012-02-19 21:40:03 PST
Created attachment 127758 [details] patch v.1
Kwonjin Jeong
Comment 2 2012-02-19 21:58:45 PST
Created attachment 127760 [details] patch v.2
Kwonjin Jeong
Comment 3 2012-02-21 17:34:05 PST
Would you give me some review about this patch? I wonder that this class is really useless or it is used by somewhere which I don't know.
Gyuyoung Kim
Comment 4 2012-05-21 08:33:54 PDT
If you still want to remove this macro, you need to refer to below url, https://trac.webkit.org/wiki/DeprecatingFeatures
Eric Seidel (no email)
Comment 5 2012-09-15 10:10:00 PDT
Comment on attachment 127760 [details] patch v.2 I suspect it might be used internally by Apple (they have non-webkit clients of WTF). But it's worth a try.
Mark Rowe (bdash)
Comment 6 2012-09-15 12:39:37 PDT
Nope.
Eric Seidel (no email)
Comment 7 2012-09-15 15:09:31 PDT
Comment on attachment 127760 [details] patch v.2 Then here we go!
WebKit Review Bot
Comment 8 2012-09-15 15:10:45 PDT
Comment on attachment 127760 [details] patch v.2 Rejecting attachment 127760 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: 2 (offset 17 lines). patching file Source/WTF/wtf/ThreadingPthreads.cpp Hunk #1 succeeded at 343 (offset 20 lines). patching file Source/WebKit/blackberry/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit/blackberry/WebCoreSupport/AboutDataHaveFeatures.in Hunk #1 succeeded at 30 with fuzz 2 (offset 8 lines). Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Eric Seidel']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/13860459
Anders Carlsson
Comment 9 2014-01-28 08:23:32 PST
This has been removed.
Note You need to log in before you can comment on or make changes to this bug.