Bug 79005

Summary: [CMAKE] Check gstreamer minimum required version
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: New BugsAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: dbates, paroga, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 79006    
Attachments:
Description Flags
Patch none

Gyuyoung Kim
Reported 2012-02-19 19:19:37 PST
To enable video requires over 0.10.30 version of GStreamer. This patch checks whether GStreamer version is over 0.10.30.
Attachments
Patch (5.31 KB, patch)
2012-02-19 20:26 PST, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2012-02-19 20:26:38 PST
Created attachment 127751 [details] Patch
Gyuyoung Kim
Comment 2 2012-02-19 20:37:54 PST
CC'ing Daniel and Patrick
Daniel Bates
Comment 3 2012-02-19 22:40:43 PST
Comment on attachment 127751 [details] Patch OK
Daniel Bates
Comment 4 2012-02-19 22:46:10 PST
Comment on attachment 127751 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=127751&action=review > Source/cmake/FindGStreamer-App.cmake:15 > +libfind_pkg_check_modules(GStreamer-App_PKGCONF gstreamer-app-0.10>=0.10.30) I'm assuming this syntax actually works.
Gyuyoung Kim
Comment 5 2012-02-19 23:07:50 PST
(In reply to comment #4) > (From update of attachment 127751 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=127751&action=review > > > Source/cmake/FindGStreamer-App.cmake:15 > > +libfind_pkg_check_modules(GStreamer-App_PKGCONF gstreamer-app-0.10>=0.10.30) > > I'm assuming this syntax actually works. Yes, this work. I verified on my linux box.
Gyuyoung Kim
Comment 6 2012-02-19 23:09:02 PST
Daniel, could you review Bug 79006 as well ?
WebKit Review Bot
Comment 7 2012-02-19 23:42:14 PST
Comment on attachment 127751 [details] Patch Clearing flags on attachment: 127751 Committed r108211: <http://trac.webkit.org/changeset/108211>
WebKit Review Bot
Comment 8 2012-02-19 23:42:20 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.