Bug 78969

Summary: [GTK] [AC] Generalize WindowContextGL
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: alex, gustavo, joone.hur, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 78968    
Attachments:
Description Flags
Patch
none
Patch also removing unused WindowContextGL gustavo: review+, webkit.review.bot: commit-queue-

Martin Robinson
Reported 2012-02-18 12:16:35 PST
WindowContextGL should become a general GL context abstraction so that it can be used by both WebGL and accelerated compositing.
Attachments
Patch (24.94 KB, patch)
2012-02-18 12:28 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Patch also removing unused WindowContextGL (29.63 KB, patch)
2012-02-18 12:32 PST, Martin Robinson 		gustavo: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2012-02-18 12:28:52 PST
Created attachment 127708 [details] Patch
Martin Robinson
Comment 2 2012-02-18 12:32:31 PST
Created attachment 127709 [details] Patch also removing unused WindowContextGL
Gustavo Noronha (kov)
Comment 3 2012-03-02 11:45:50 PST
Comment on attachment 127709 [details] Patch also removing unused WindowContextGL LGTM
WebKit Review Bot
Comment 4 2012-03-02 12:13:22 PST
Comment on attachment 127709 [details] Patch also removing unused WindowContextGL Rejecting attachment 127709 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: /graphics/gtk/WindowGLContext.h' patching file Source/WebCore/platform/graphics/gtk/WindowGLContextGLX.cpp rm 'Source/WebCore/platform/graphics/gtk/WindowGLContextGLX.cpp' patching file Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContext.h patching file Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContextGL.cpp Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Gustavo No..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/11802076
Martin Robinson
Comment 5 2012-03-02 13:08:17 PST
Committed r109605: <http://trac.webkit.org/changeset/109605>
Note You need to log in before you can comment on or make changes to this bug.