Summary: | [Qt][WK2] Accelerated animations don't work on Mac | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Noam Rosenthal <noam> | ||||
Component: | Layout and Rendering | Assignee: | Noam Rosenthal <noam> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | kenneth, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Noam Rosenthal
2012-02-18 05:17:03 PST
Created attachment 127842 [details]
Patch
Comment on attachment 127842 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=127842&action=review > Source/WebKit2/UIProcess/qt/LayerTreeHostProxyQt.cpp:205 > + TextureMapperLayer* layer = toTextureMapperLayer(rootLayer()); > + ASSERT(layer); Shouldn't that assert not be in toTextureMapperLayer ? (In reply to comment #2) > (From update of attachment 127842 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=127842&action=review > > > Source/WebKit2/UIProcess/qt/LayerTreeHostProxyQt.cpp:205 > > + TextureMapperLayer* layer = toTextureMapperLayer(rootLayer()); > > + ASSERT(layer); > > Shouldn't that assert not be in toTextureMapperLayer ? No, sometimes it's ok to have NULL. Comment on attachment 127842 [details] Patch Clearing flags on attachment: 127842 Committed r108405: <http://trac.webkit.org/changeset/108405> All reviewed patches have been landed. Closing bug. |