Bug 78945

Summary: Separate the implementation of registerProtocolHandler from Navigator.cpp
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch eric: review+, abarth: commit-queue+

Adam Barth
Reported 2012-02-17 16:34:30 PST
Separate the implementation of registerProtocolHandler from Navigator.cpp
Attachments
Patch (21.79 KB, patch)
2012-02-17 16:37 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (26.17 KB, patch)
2012-02-21 23:00 PST, Adam Barth 		eric: review+
abarth: commit-queue+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-02-17 16:37:24 PST
Created attachment 127675 [details] Patch
Adam Barth
Comment 2 2012-02-17 16:38:02 PST
I'm not entirely convinced that this is the best way to solve this problem. Another approach is to have a free function for registerProtocolHandler that Navigator.cpp calls.
Eric Seidel (no email)
Comment 3 2012-02-17 16:40:26 PST
Comment on attachment 127675 [details] Patch Seems reasonable. Looks like you're just moving code, and adding a new Suplemental=Navigator idl file. Is my understanding correct?
Adam Barth
Comment 4 2012-02-17 16:50:57 PST
Yes, and changing references to m_frame to navigator->frame().
Adam Barth
Comment 5 2012-02-21 23:00:07 PST
Created attachment 128137 [details] Patch
Eric Seidel (no email)
Comment 6 2012-02-21 23:02:28 PST
Comment on attachment 128137 [details] Patch LGTM.
Adam Barth
Comment 7 2012-02-21 23:27:39 PST
Committed r108450: <http://trac.webkit.org/changeset/108450>
Note You need to log in before you can comment on or make changes to this bug.