Bug 78939

Summary: Remove the remaining uses of CSSStyleDeclaration in Editor
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: New BugsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: enrica, gustavo, koivisto, pnormand, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
enrica: review+
Updated for ToT
none
GTK and Windows build fixes none

Ryosuke Niwa
Reported 2012-02-17 15:11:38 PST
Remove the remaining uses of CSSStyleDeclaration in Editor
Attachments
Patch (43.08 KB, patch)
2012-02-17 15:12 PST, Ryosuke Niwa 		enrica: review+
DetailsFormatted DiffDiff
Updated for ToT (40.85 KB, patch)
2012-02-21 11:19 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
GTK and Windows build fixes (41.48 KB, patch)
2012-02-21 12:00 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2012-02-17 15:12:45 PST
Created attachment 127663 [details] Patch
Ryosuke Niwa
Comment 2 2012-02-21 10:44:38 PST
Comment on attachment 127663 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=127663&action=review > Source/WebCore/ChangeLog:8 > + No new tests. (OOPS!) Oops, this comment should go away.
Ryosuke Niwa
Comment 3 2012-02-21 11:19:36 PST
Created attachment 128005 [details] Updated for ToT
Philippe Normand
Comment 4 2012-02-21 11:23:46 PST
Comment on attachment 128005 [details] Updated for ToT Attachment 128005 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11556199
Ryosuke Niwa
Comment 5 2012-02-21 12:00:03 PST
Created attachment 128015 [details] GTK and Windows build fixes
Enrica Casucci
Comment 6 2012-02-21 12:04:45 PST
Comment on attachment 127663 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=127663&action=review Looks good to me. Great job, BTW :-). Please make sure you check the EWS before landing. I saw you already fixed some build breakage. > Source/WebCore/ChangeLog:22 > + (Editor): The 2 lines above don't add any information. > Source/WebCore/ChangeLog:35 > + (EditorClient): Ditto. > Source/WebKit/mac/WebView/WebFrame.mm:802 > + // FIXME: We shouldn't have to create a copy here. This comment should be as detailed as the one on line 4356 of WebHTMLView.mm. > Source/WebKit/mac/WebView/WebHTMLView.mm:4658 > + // FIXME: We shouldn't have to make a copy here. Same here. > Source/WebKit/mac/WebView/WebView.mm:5528 > + // FIXME: We shouldn't have to make a copy here. Same here.
WebKit Review Bot
Comment 7 2012-02-22 01:14:43 PST
Comment on attachment 128015 [details] GTK and Windows build fixes Clearing flags on attachment: 128015 Committed r108462: <http://trac.webkit.org/changeset/108462>
WebKit Review Bot
Comment 8 2012-02-22 01:14:48 PST
All reviewed patches have been landed. Closing bug.
Ryosuke Niwa
Comment 9 2012-02-22 15:39:35 PST
Committed r108562: <http://trac.webkit.org/changeset/108562>
Note You need to log in before you can comment on or make changes to this bug.