Bug 78926

Summary: Full Screen Refactor Part 2: Remove unnecessary WebKit2 APIs for Full Screen made
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: WebKit2Assignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, menard, pnormand, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 78925    
Bug Blocks: 78927, 78928, 78930    
Attachments:
Description Flags
Patch
none
Patch sullivan: review+

Jer Noble
Reported 2012-02-17 13:31:06 PST
Now that (bug #78925) compositing mode is no longer used in full-screen mode, remove the WebKit2 APIs which handle these modes.
Attachments
Patch (48.96 KB, patch)
2012-02-17 13:59 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (56.57 KB, patch)
2012-02-20 14:27 PST, Jer Noble 		sullivan: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2012-02-17 13:59:33 PST
Created attachment 127651 [details] Patch
Jer Noble
Comment 2 2012-02-20 14:27:37 PST
Created attachment 127850 [details] Patch Removed Source/WebKit2/WebProcess/FullScreen/win/WebFullScreenManagerWin.cpp,h
John Sullivan
Comment 3 2012-02-21 11:25:21 PST
Comment on attachment 127850 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=127850&action=review > Source/WebKit2/UIProcess/WebFullScreenManagerProxy.h:85 > + void disposeOfLayerClient() { } // FIXME: Remove These “// FIXME: Remove” comments don’t provide enough context. Is there a bug number about removing them that you could cite here? Otherwise, they need more context about when they can/should be removed.
Jer Noble
Comment 4 2012-02-21 11:27:57 PST
(In reply to comment #3) > (From update of attachment 127850 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=127850&action=review > > > Source/WebKit2/UIProcess/WebFullScreenManagerProxy.h:85 > > + void disposeOfLayerClient() { } // FIXME: Remove > > These “// FIXME: Remove” comments don’t provide enough context. Is there a bug number about removing them that you could cite here? Otherwise, they need more context about when they can/should be removed. Yes, these will be fully removed by the patch in bug #78928. I'll add that to the comment.
Jer Noble
Comment 5 2012-03-08 15:16:54 PST
Committed r110214: <http://trac.webkit.org/changeset/110214>
Note You need to log in before you can comment on or make changes to this bug.