Bug 78895

Summary: Web Inspector: check undo-redo boundaries based on current action index, not history size.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch vsevik: review+

Pavel Feldman
Reported 2012-02-17 05:50:02 PST
Patch to follow.
Attachments
Patch (5.00 KB, patch)
2012-02-17 05:51 PST, Pavel Feldman 		vsevik: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2012-02-17 05:51:40 PST
Created attachment 127577 [details] Patch
Vsevolod Vlasov
Comment 2 2012-02-17 08:01:48 PST
Comment on attachment 127577 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=127577&action=review > Source/WebCore/inspector/InspectorHistory.cpp:93 > + if (!action->mergeId().isEmpty() && m_afterLastActionIndex > 0 && m_afterLastActionIndex < m_history.size() && action->mergeId() == m_history[m_afterLastActionIndex - 1]->mergeId()) Please remove second condition
Pavel Feldman
Comment 3 2012-02-17 08:14:17 PST
Committed r108075: <http://trac.webkit.org/changeset/108075>
Note You need to log in before you can comment on or make changes to this bug.