Summary: | perf-o-matic needs model unit tests | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||
Component: | Tools / Tests | Assignee: | Ryosuke Niwa <rniwa> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, morrita | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 77037 | ||||||
Attachments: |
|
Description
Ryosuke Niwa
2012-02-17 02:00:31 PST
Created attachment 127554 [details]
Adds some unit tests
Comment on attachment 127554 [details] Adds some unit tests View in context: https://bugs.webkit.org/attachment.cgi?id=127554&action=review > Websites/webkit-perf.appspot.com/models_unittest.py:272 > +if __name__ == '__main__': > + unittest.main() Is this test wired into test-webkitpy? We have some tests from the QueueStatusServer wired in if you want to see how it's done. (In reply to comment #2) > (From update of attachment 127554 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=127554&action=review > > > Websites/webkit-perf.appspot.com/models_unittest.py:272 > > +if __name__ == '__main__': > > + unittest.main() > > Is this test wired into test-webkitpy? We have some tests from the QueueStatusServer wired in if you want to see how it's done. Not at the moment. I think we want to move the entire directory into Tools first if we're going to do that. Comment on attachment 127554 [details] Adds some unit tests Clearing flags on attachment: 127554 Committed r108094: <http://trac.webkit.org/changeset/108094> All reviewed patches have been landed. Closing bug. |