Bug 78885

Summary: perf-o-matic needs model unit tests
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, morrita
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 77037    
Attachments:
Description Flags
Adds some unit tests none

Ryosuke Niwa
Reported 2012-02-17 02:00:31 PST
We need some tests.
Attachments
Adds some unit tests (24.10 KB, patch)
2012-02-17 02:05 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2012-02-17 02:05:34 PST
Created attachment 127554 [details] Adds some unit tests
Adam Barth
Comment 2 2012-02-17 10:41:57 PST
Comment on attachment 127554 [details] Adds some unit tests View in context: https://bugs.webkit.org/attachment.cgi?id=127554&action=review > Websites/webkit-perf.appspot.com/models_unittest.py:272 > +if __name__ == '__main__': > + unittest.main() Is this test wired into test-webkitpy? We have some tests from the QueueStatusServer wired in if you want to see how it's done.
Ryosuke Niwa
Comment 3 2012-02-17 10:43:39 PST
(In reply to comment #2) > (From update of attachment 127554 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=127554&action=review > > > Websites/webkit-perf.appspot.com/models_unittest.py:272 > > +if __name__ == '__main__': > > + unittest.main() > > Is this test wired into test-webkitpy? We have some tests from the QueueStatusServer wired in if you want to see how it's done. Not at the moment. I think we want to move the entire directory into Tools first if we're going to do that.
Ryosuke Niwa
Comment 4 2012-02-17 10:47:09 PST
Comment on attachment 127554 [details] Adds some unit tests Clearing flags on attachment: 127554 Committed r108094: <http://trac.webkit.org/changeset/108094>
Ryosuke Niwa
Comment 5 2012-02-17 10:47:20 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.