Bug 78868

Summary: Move textDirectionForSelection from Editor to EditingStyle
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: New BugsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, enrica, koivisto
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch enrica: review+

Ryosuke Niwa
Reported 2012-02-16 19:25:29 PST
Move textDirectionForSelection from Editor to EditingStyle
Attachments
Patch (14.86 KB, patch)
2012-02-16 19:26 PST, Ryosuke Niwa 		enrica: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2012-02-16 19:26:35 PST
Created attachment 127499 [details] Patch
Ryosuke Niwa
Comment 2 2012-02-16 19:29:43 PST
Per discussion we had on Tue, I'm moving all editing code's dependency on CSStyleDeclaration into EditingStyle so that we can get rid of them more easily.
Enrica Casucci
Comment 3 2012-02-17 12:57:04 PST
Comment on attachment 127499 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=127499&action=review Looks good to me. Please make sure you don't check in the changes to the project. File. > Source/WebCore/ChangeLog:11 > + * WebCore.xcodeproj/project.pbxproj: This should be removed > Source/WebCore/ChangeLog:16 > + (EditingStyle): I normally remove these lines, since they don't add any valuable information. > Source/WebCore/WebCore.xcodeproj/project.pbxproj:7388 > + 1C435CD514E8545B004E10EA /* Inspector-1.0.json */ = {isa = PBXFileReference; lastKnownFileType = text; path = "Inspector-1.0.json"; sourceTree = "<group>"; }; I don't think this is part of this patch.
Ryosuke Niwa
Comment 4 2012-02-17 15:57:13 PST
Committed r108137: <http://trac.webkit.org/changeset/108137>
Note You need to log in before you can comment on or make changes to this bug.