Bug 78865

Summary: [Chromium] Include TestShellLinux.cpp in the build for Android
Product: WebKit Reporter: Peter Beverloo <peter>
Component: New BugsAssignee: Peter Beverloo <peter>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Peter Beverloo
Reported 2012-02-16 17:49:45 PST
[Chromium] Include TestShellLinux.cpp in the build for Android
Attachments
Patch (1.46 KB, patch)
2012-02-16 17:52 PST, Peter Beverloo 		no flags
DetailsFormatted DiffDiff
Patch (1.49 KB, patch)
2012-02-17 09:26 PST, Peter Beverloo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Peter Beverloo
Comment 1 2012-02-16 17:52:14 PST
Created attachment 127486 [details] Patch
Eric Seidel (no email)
Comment 2 2012-02-16 18:29:10 PST
Comment on attachment 127486 [details] Patch Wow, it's still called TestShell... amazing. :)
WebKit Review Bot
Comment 3 2012-02-16 21:00:06 PST
Comment on attachment 127486 [details] Patch Rejecting attachment 127486 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/11535428
Peter Beverloo
Comment 4 2012-02-16 22:10:59 PST
Oh wow, how did I manage to rip that out. Sorry, I'll fix and land in the morning.
Peter Beverloo
Comment 5 2012-02-17 09:26:47 PST
Created attachment 127605 [details] Patch
Peter Beverloo
Comment 6 2012-02-17 09:27:38 PST
Comment on attachment 127605 [details] Patch Pushing this on the CQ.
WebKit Review Bot
Comment 7 2012-02-17 10:10:06 PST
Comment on attachment 127605 [details] Patch Clearing flags on attachment: 127605 Committed r108090: <http://trac.webkit.org/changeset/108090>
WebKit Review Bot
Comment 8 2012-02-17 10:10:10 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.