Bug 78859

Summary:

[chromium] Re-enable compositing/culling/scrolled-within-boxshadow.html

Product:

WebKit

Reporter:

Dana Jansens <danakj>

Component:

New Bugs

Assignee:

Dana Jansens <danakj>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

jamesr, noel.gordon, tony, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

78755

Attachments:

Description	Flags
Patch	none
Patch for landing	webkit.review.bot: commit-queue-

Dana Jansens

Reported 2012-02-16 17:07:03 PST

[chromium] Re-enable compositing/culling/scrolled-within-boxshadow.html

Attachments
Patch (1.53 KB, patch) 2012-02-16 17:07 PST, Dana Jansens	no flags	Details Formatted Diff Diff
Patch for landing (1.36 KB, patch) 2012-02-17 10:39 PST, W. James MacLean	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Dana Jansens

Comment 1 2012-02-16 17:07:30 PST

Created attachment 127474 [details] Patch

Dana Jansens

Comment 2 2012-02-16 17:08:34 PST

Fixed in https://bugs.webkit.org/show_bug.cgi?id=78775

Dana Jansens

Comment 3 2012-02-16 17:09:14 PST

Comment on attachment 127474 [details] Patch Just waiting for win bot to complete. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=compositing%2Fculling%2Fscrolled-within-boxshadow.html%2Ccompositing%2Fculling%2Funscrolled-within-boxshadow.html%2C&showAllRuns=true

noel gordon

Comment 4 2012-02-16 17:43:34 PST

LGTM.

Dana Jansens

Comment 5 2012-02-16 17:50:34 PST

Comment on attachment 127474 [details] Patch builders are all green!

noel gordon

Comment 6 2012-02-16 18:03:24 PST

Awesome. Tony, this looks good to me, can you provide the r+?

WebKit Review Bot

Comment 7 2012-02-17 10:29:12 PST

Comment on attachment 127474 [details] Patch Rejecting attachment 127474 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: /mnt/git/webkit-commit-queue/ Parsed 2 diffs from patch file(s). patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/platform/chromium/test_expectations.txt Hunk #1 FAILED at 4201. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/chromium/test_expectations.txt.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'James Robi..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/11536609

W. James MacLean

Comment 8 2012-02-17 10:39:39 PST

Created attachment 127609 [details] Patch for landing

WebKit Review Bot

Comment 9 2012-02-17 13:30:22 PST

Comment on attachment 127609 [details] Patch for landing Rejecting attachment 127609 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Parsed 2 diffs from patch file(s). patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/platform/chromium/test_expectations.txt Hunk #1 FAILED at 4203. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/chromium/test_expectations.txt.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/11541501

James Robinson

Comment 10 2012-02-17 13:31:02 PST

I would strongly advice you just land this by hand and not attempt to use commit-queue.

Dana Jansens

Comment 11 2012-02-17 13:36:40 PST

Committed r108115: <http://trac.webkit.org/changeset/108115>

Note You need to log in before you can comment on or make changes to this bug.