Summary: | [chromium] Re-enable compositing/culling/scrolled-within-boxshadow.html | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dana Jansens <danakj> | ||||||
Component: | New Bugs | Assignee: | Dana Jansens <danakj> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | jamesr, noel.gordon, tony, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 78755 | ||||||||
Attachments: |
|
Description
Dana Jansens
2012-02-16 17:07:03 PST
Created attachment 127474 [details]
Patch
Comment on attachment 127474 [details] Patch Just waiting for win bot to complete. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=compositing%2Fculling%2Fscrolled-within-boxshadow.html%2Ccompositing%2Fculling%2Funscrolled-within-boxshadow.html%2C&showAllRuns=true LGTM. Comment on attachment 127474 [details]
Patch
builders are all green!
Awesome. Tony, this looks good to me, can you provide the r+? Comment on attachment 127474 [details] Patch Rejecting attachment 127474 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: /mnt/git/webkit-commit-queue/ Parsed 2 diffs from patch file(s). patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/platform/chromium/test_expectations.txt Hunk #1 FAILED at 4201. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/chromium/test_expectations.txt.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'James Robi..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/11536609 Created attachment 127609 [details]
Patch for landing
Comment on attachment 127609 [details] Patch for landing Rejecting attachment 127609 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Parsed 2 diffs from patch file(s). patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/platform/chromium/test_expectations.txt Hunk #1 FAILED at 4203. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/chromium/test_expectations.txt.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/11541501 I would strongly advice you just land this by hand and not attempt to use commit-queue. Committed r108115: <http://trac.webkit.org/changeset/108115> |