Bug 78844

Summary:

Chrome::*Geolocation* are just useless pass-throughs to ChromeClient and should be removed

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

New Bugs

Assignee:

Adam Barth <abarth>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	eric: review+, eric: commit-queue-

Description Adam Barth 2012-02-16 14:43:13 PST

Chrome::*Geolocation* are just useless pass-throughs to ChromeClient and should be removed

Comment 1 Adam Barth 2012-02-16 14:44:16 PST

Created attachment 127445 [details]
Patch

Comment 2 Eric Seidel (no email) 2012-02-16 14:45:50 PST

Comment on attachment 127445 [details]
Patch

Don't you have a header import to remove in Chrome.cpp?

Comment 3 Adam Barth 2012-02-16 14:49:10 PST

> Don't you have a header import to remove in Chrome.cpp?

There's still some code in Chrome.cpp that uses ChromeClient.h

Comment 4 Adam Barth 2012-02-16 14:50:17 PST

Committed r107982: <http://trac.webkit.org/changeset/107982>