Bug 78844

Summary:

Chrome::*Geolocation* are just useless pass-throughs to ChromeClient and should be removed

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

New Bugs

Assignee:

Adam Barth <abarth>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	eric: review+, eric: commit-queue-

Adam Barth

Reported 2012-02-16 14:43:13 PST

Chrome::*Geolocation* are just useless pass-throughs to ChromeClient and should be removed

Attachments
Patch (3.40 KB, patch) 2012-02-16 14:44 PST, Adam Barth	eric: review+ eric: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Adam Barth

Comment 1 2012-02-16 14:44:16 PST

Eric Seidel (no email)

Comment 2 2012-02-16 14:45:50 PST

Comment on attachment 127445 [details] Patch Don't you have a header import to remove in Chrome.cpp?

Adam Barth

Comment 3 2012-02-16 14:49:10 PST

> Don't you have a header import to remove in Chrome.cpp? There's still some code in Chrome.cpp that uses ChromeClient.h

Adam Barth

Comment 4 2012-02-16 14:50:17 PST

Note You need to log in before you can comment on or make changes to this bug.