WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
78844
Chrome::*Geolocation* are just useless pass-throughs to ChromeClient and should be removed
https://bugs.webkit.org/show_bug.cgi?id=78844
Summary
Chrome::*Geolocation* are just useless pass-throughs to ChromeClient and shou...
Adam Barth
Reported
2012-02-16 14:43:13 PST
Chrome::*Geolocation* are just useless pass-throughs to ChromeClient and should be removed
Attachments
Patch
(3.40 KB, patch)
2012-02-16 14:44 PST
,
Adam Barth
eric
: review+
eric
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Adam Barth
Comment 1
2012-02-16 14:44:16 PST
Created
attachment 127445
[details]
Patch
Eric Seidel (no email)
Comment 2
2012-02-16 14:45:50 PST
Comment on
attachment 127445
[details]
Patch Don't you have a header import to remove in Chrome.cpp?
Adam Barth
Comment 3
2012-02-16 14:49:10 PST
> Don't you have a header import to remove in Chrome.cpp?
There's still some code in Chrome.cpp that uses ChromeClient.h
Adam Barth
Comment 4
2012-02-16 14:50:17 PST
Committed
r107982
: <
http://trac.webkit.org/changeset/107982
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug