Bug 78844 - Chrome::*Geolocation* are just useless pass-throughs to ChromeClient and should be removed
Summary: Chrome::*Geolocation* are just useless pass-throughs to ChromeClient and shou...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-16 14:43 PST by Adam Barth
Modified: 2012-02-16 14:50 PST (History)
1 user (show)

See Also:

Attachments
Patch (3.40 KB, patch)
2012-02-16 14:44 PST, Adam Barth 		eric: review+
eric: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-02-16 14:43:13 PST 
Chrome::*Geolocation* are just useless pass-throughs to ChromeClient and should be removed
Comment 1 Adam Barth 2012-02-16 14:44:16 PST 
Created attachment 127445 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-02-16 14:45:50 PST 
Comment on attachment 127445 [details]
Patch

Don't you have a header import to remove in Chrome.cpp?
Comment 3 Adam Barth 2012-02-16 14:49:10 PST 
> Don't you have a header import to remove in Chrome.cpp?

There's still some code in Chrome.cpp that uses ChromeClient.h
Comment 4 Adam Barth 2012-02-16 14:50:17 PST 
Committed r107982: <http://trac.webkit.org/changeset/107982>