Bug 78837

Summary: [chromium] Cleanup unused WebDragData methods after r107846
Product: WebKit Reporter: Daniel Cheng <dcheng>
Component: New BugsAssignee: Daniel Cheng <dcheng>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
EWS run?
none
Fix layout test and crbug.com/115015
none
Patch tony: review+

Daniel Cheng
Reported 2012-02-16 13:48:59 PST
[chromium] Cleanup unused WebDragData methods after r107846
Attachments
Patch (10.76 KB, patch)
2012-02-16 13:53 PST, Daniel Cheng 		no flags
DetailsFormatted DiffDiff
EWS run? (10.79 KB, patch)
2012-02-17 11:59 PST, Daniel Cheng 		no flags
DetailsFormatted DiffDiff
Fix layout test and crbug.com/115015 (11.21 KB, patch)
2012-02-21 14:06 PST, Daniel Cheng 		no flags
DetailsFormatted DiffDiff
Patch (7.65 KB, patch)
2012-02-21 17:10 PST, Daniel Cheng 		tony: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Daniel Cheng
Comment 1 2012-02-16 13:53:11 PST
Created attachment 127435 [details] Patch
Daniel Cheng
Comment 2 2012-02-16 13:54:03 PST
This is a followup to r107846. Once the Source/WebKit/chromium/DEPS is rolled, I will land this patch.
Daniel Cheng
Comment 3 2012-02-17 11:59:24 PST
Created attachment 127627 [details] EWS run?
WebKit Review Bot
Comment 4 2012-02-17 17:04:44 PST
Comment on attachment 127627 [details] EWS run? Attachment 127627 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11539636 New failing tests: fast/events/drag-image-filename.html
Daniel Cheng
Comment 5 2012-02-17 17:12:50 PST
Argh. This layout test exercises a code path that's never used in the actual browser, but is tickled by DRT. I'm going to have to think of a good way to fix this...
Daniel Cheng
Comment 6 2012-02-21 14:06:22 PST
Created attachment 128039 [details] Fix layout test and crbug.com/115015
Daniel Cheng
Comment 7 2012-02-21 17:10:07 PST
Created attachment 128087 [details] Patch
Tony Chang
Comment 8 2012-02-22 09:52:49 PST
Comment on attachment 128087 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128087&action=review > Source/WebKit/chromium/src/WebDragData.cpp:135 > + ensureMutable(); What is this for? Can you mention it in the ChangeLog?
Daniel Cheng
Comment 9 2012-02-22 14:52:11 PST
Committed r108554: <http://trac.webkit.org/changeset/108554>
Note You need to log in before you can comment on or make changes to this bug.