Bug 78824

Summary: [Qt][WK2] Allow partial updates
Product: WebKit Reporter: Noam Rosenthal <noam>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann, jturcotte, kenneth, webkit.review.bot
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
hausmann: review+
Patch none

Noam Rosenthal
Reported 2012-02-16 09:09:44 PST
Currently our updates include complete tiles, even when only a small part of the tile is updated. this creates unnecessary large uploads. Since the original reason to do things this way is gone, we should only create buffers when we need them.
Attachments
Patch (9.87 KB, patch)
2012-02-16 23:57 PST, Noam Rosenthal 		hausmann: review+
DetailsFormatted DiffDiff
Patch (9.87 KB, patch)
2012-02-17 02:02 PST, Noam Rosenthal 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Noam Rosenthal
Comment 1 2012-02-16 23:57:28 PST
Created attachment 127538 [details] Patch
Simon Hausmann
Comment 2 2012-02-17 00:03:12 PST
Comment on attachment 127538 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=127538&action=review Good morning ;) > Source/WebKit2/UIProcess/qt/LayerTreeHostProxyQt.cpp:510 > + ASSERT(!updateInfo.updateRects.isEmpty()); Would it perhaps make sense to ASSERT on size() == 1 instead of !isEmpty()? After all it looks like you're dealing with only one rect anyway?
Noam Rosenthal
Comment 3 2012-02-17 01:00:56 PST
> > Source/WebKit2/UIProcess/qt/LayerTreeHostProxyQt.cpp:510 > > + ASSERT(!updateInfo.updateRects.isEmpty()); > > Would it perhaps make sense to ASSERT on size() == 1 instead of !isEmpty()? After all it looks like you're dealing with only one rect anyway? Sure, why not.
Simon Hausmann
Comment 4 2012-02-17 01:39:10 PST
Comment on attachment 127538 [details] Patch r=me with the ASSERT suggestion :)
Noam Rosenthal
Comment 5 2012-02-17 02:02:53 PST
Created attachment 127552 [details] Patch
WebKit Review Bot
Comment 6 2012-02-17 03:09:24 PST
Comment on attachment 127552 [details] Patch Clearing flags on attachment: 127552 Committed r108055: <http://trac.webkit.org/changeset/108055>
WebKit Review Bot
Comment 7 2012-02-17 03:09:28 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.