| Summary: | [Qt] Signal and property cleanup in QQuickWebView | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Hausmann <hausmann> | ||||
| Component: | WebKit API | Assignee: | Jocelyn Turcotte <jturcotte> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cmarcelo, ossy, vestbo, webkit.review.bot, zalan | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | 79562 | ||||||
| Bug Blocks: | 74403 | ||||||
| Attachments: |
|
||||||
The loading signals part is tracked in bug #79486. Created attachment 128727 [details]
Patch
Committed r108816: <http://trac.webkit.org/changeset/108816> (In reply to comment #3) > Committed r108816: <http://trac.webkit.org/changeset/108816> Reopen, because it made many tests crash and timeout. :( http://build.webkit.sed.hu/results/x86-32%20Linux%20Qt%20Release%20WebKit2/r108817%20%2820727%29/results.html It made layout tests exiting early, so the test coverage is near 0% now. :(( Rollout landed in http://trac.webkit.org/changeset/108889 Comment on attachment 128727 [details] Patch Resubmitting after http://trac.webkit.org/changeset/109121 landed, which should fix the crash. I'm still seeing one or two crashes on my machine that I can't sucessfully tie to this patch, so I'm pushing it once more with a 80% confidence it shouldn't crash. Comment on attachment 128727 [details] Patch Rejecting attachment 128727 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/WebKit2/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/11711013 Comment on attachment 128727 [details]
Patch
To Jocelyn's request, reapplying r+ and cq+.
Comment on attachment 128727 [details] Patch Clearing flags on attachment: 128727 Committed r109130: <http://trac.webkit.org/changeset/109130> All reviewed patches have been landed. Closing bug. |
As discussed in the API review session in Szeged, there are a few straight-forward changes to the properties and signals of QQuickWebView that we should do before the release: * Remove canReload * Remove parameter from titleChanged, urlChanged, iconChanged, loadProgressChanged * loadFailed: change signature to loadFailed(failedUrl, description, errorDomain, errorCode) * linkHovered should be linkHovered(hoveredUrl, hoveredTitle) * Get rid of loadStarted and loadSucceeded, add loadingChanged instead * Remove navigationStateChanged, add canGoBackChanged and canGoForwardChanged For future reference let me try to recall the reasons we came up with in the discussion: * canReload is redundant in the face of "loading", the implementation of the one is the reverse of the other. * The parameters to the *Changed signals are redundant and usually not present in other QML modules. * The parameters in loadFailed should be ordered by importance and we should use failedUrl instead of url to avoid shadowing the WebView's url property * loadStarted and loadSuceeded are redundant in the face of a notification signal of the loading property: loadingChanged. If the loading property is true in the slot connected to the loadingChanged signal, then the load started, if the value is false the load finished. * The url and title properties in linkHovered should be renamed to avoid shadowing