| Summary: | Web Inspector: move style disable checkboxes to the left | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Pavel Feldman <pfeldman> | ||||||||||
| Component: | Web Inspector (Deprecated) | Assignee: | Pavel Feldman <pfeldman> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, lensco, loislo, pfeldman, pmuellr, rik, timothy, yurys | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | All | ||||||||||||
| OS: | All | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Pavel Feldman
2012-02-15 22:46:05 PST
Created attachment 127313 [details]
[IMAGE] Screenshot with patch applied.
Created attachment 127362 [details]
[IMAGE] Looks with patch applied.
Created attachment 127363 [details]
Patch
Comment on attachment 127363 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=127363&action=review Please add some space between checkbox and style. > Source/WebCore/inspector/front-end/StylesSidebarPane.js:-1770 > - if (enabledCheckboxElement && this.treeOutline.section && this.treeOutline.section.editable && this.parent.root) Isn't that breaking computed style? r- for that. > Source/WebCore/inspector/front-end/StylesSidebarPane.js:-1935 > - this.hasChildren = false; Please keep lying. > Source/WebCore/inspector/front-end/StylesSidebarPane.js:-2092 > - this.hasChildren = context.hasChildren; ditto. (In reply to comment #4) > (From update of attachment 127363 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=127363&action=review > > Please add some space between checkbox and style. > Done. > > Source/WebCore/inspector/front-end/StylesSidebarPane.js:-1770 > > - if (enabledCheckboxElement && this.treeOutline.section && this.treeOutline.section.editable && this.parent.root) > > Isn't that breaking computed style? r- for that. > Done. > > Source/WebCore/inspector/front-end/StylesSidebarPane.js:-1935 > > - this.hasChildren = false; > > Please keep lying. > Done. > > Source/WebCore/inspector/front-end/StylesSidebarPane.js:-2092 > > - this.hasChildren = context.hasChildren; > > ditto. Done. Created attachment 127368 [details]
Patch
Comment on attachment 127368 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=127368&action=review > Source/WebCore/inspector/front-end/elementsPanel.css:398 > + opacity: 0; visibility: hidden; seems more appropriate in this case > Source/WebCore/inspector/front-end/treeoutline.js:867 > else if (element.treeElement.hasChildren && !element.treeElement.expanded) Should go on the previous line, after '}' Committed r107933: <http://trac.webkit.org/changeset/107933> |