Bug 78780

Summary:

Web Inspector: move style disable checkboxes to the left

Product:

WebKit

Reporter:

Pavel Feldman <pfeldman>

Component:

Web Inspector (Deprecated)

Assignee:

Pavel Feldman <pfeldman>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, lensco, loislo, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[IMAGE] Screenshot with patch applied.	none
[IMAGE] Looks with patch applied.	none
Patch	none
Patch	vsevik: review+

Pavel Feldman

Reported 2012-02-15 22:46:05 PST

Screenshot to follow.

Attachments
[IMAGE] Screenshot with patch applied. (61.94 KB, image/png) 2012-02-15 22:46 PST, Pavel Feldman	no flags	Details
[IMAGE] Looks with patch applied. (72.03 KB, image/png) 2012-02-16 05:45 PST, Pavel Feldman	no flags	Details
Patch (9.75 KB, patch) 2012-02-16 05:47 PST, Pavel Feldman	no flags	Details Formatted Diff Diff
Patch (9.05 KB, patch) 2012-02-16 06:13 PST, Pavel Feldman	vsevik: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Pavel Feldman

Comment 1 2012-02-15 22:46:28 PST

Created attachment 127313 [details] [IMAGE] Screenshot with patch applied.

Pavel Feldman

Comment 2 2012-02-16 05:45:21 PST

Created attachment 127362 [details] [IMAGE] Looks with patch applied.

Pavel Feldman

Comment 3 2012-02-16 05:47:12 PST

Created attachment 127363 [details] Patch

Vsevolod Vlasov

Comment 4 2012-02-16 06:09:55 PST

Comment on attachment 127363 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=127363&action=review Please add some space between checkbox and style. > Source/WebCore/inspector/front-end/StylesSidebarPane.js:-1770 > - if (enabledCheckboxElement && this.treeOutline.section && this.treeOutline.section.editable && this.parent.root) Isn't that breaking computed style? r- for that. > Source/WebCore/inspector/front-end/StylesSidebarPane.js:-1935 > - this.hasChildren = false; Please keep lying. > Source/WebCore/inspector/front-end/StylesSidebarPane.js:-2092 > - this.hasChildren = context.hasChildren; ditto.

Pavel Feldman

Comment 5 2012-02-16 06:12:37 PST

(In reply to comment #4) > (From update of attachment 127363 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=127363&action=review > > Please add some space between checkbox and style. > Done. > > Source/WebCore/inspector/front-end/StylesSidebarPane.js:-1770 > > - if (enabledCheckboxElement && this.treeOutline.section && this.treeOutline.section.editable && this.parent.root) > > Isn't that breaking computed style? r- for that. > Done. > > Source/WebCore/inspector/front-end/StylesSidebarPane.js:-1935 > > - this.hasChildren = false; > > Please keep lying. > Done. > > Source/WebCore/inspector/front-end/StylesSidebarPane.js:-2092 > > - this.hasChildren = context.hasChildren; > > ditto. Done.

Pavel Feldman

Comment 6 2012-02-16 06:13:14 PST

Created attachment 127368 [details] Patch

Alexander Pavlov (apavlov)

Comment 7 2012-02-16 06:23:58 PST

Comment on attachment 127368 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=127368&action=review > Source/WebCore/inspector/front-end/elementsPanel.css:398 > + opacity: 0; visibility: hidden; seems more appropriate in this case > Source/WebCore/inspector/front-end/treeoutline.js:867 > else if (element.treeElement.hasChildren && !element.treeElement.expanded) Should go on the previous line, after '}'

Pavel Feldman

Comment 8 2012-02-16 07:34:35 PST

Committed r107933: <http://trac.webkit.org/changeset/107933>

Alexander Pavlov (apavlov)

Comment 9 2012-02-17 03:44:20 PST

*** Bug 37770 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.