Bug 78774

Summary:

Fix the broken viewport tests

Product:

WebKit

Reporter:

Mark Hahnenberg <mhahnenberg>

Component:

JavaScriptCore

Assignee:

Mark Hahnenberg <mhahnenberg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

joepeck, kenneth

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

68044

Attachments:

Description	Flags
Patch	none
Patch	kenneth: review+

Description Mark Hahnenberg 2012-02-15 19:34:58 PST

The patch for bug 68044 broke a few tests in fast/viewport. We should fix these for the platforms that support them.

Comment 1 Mark Hahnenberg 2012-02-15 19:44:25 PST

Created attachment 127298 [details]
Patch

Comment 2 Mark Hahnenberg 2012-02-15 21:17:41 PST

Created attachment 127308 [details]
Patch

Comment 3 Kenneth Rohde Christiansen 2012-02-16 02:07:53 PST

Comment on attachment 127308 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127308&action=review

> Source/JavaScriptCore/wtf/text/WTFString.h:90
> +WTF_EXPORT_PRIVATE float charactersToFloatWithJunk(const LChar*, size_t, bool* ok = 0, bool* didReadNumber = 0);

Maybe charactersToFloatIgnoringJunk would be more descriptive?

> Source/JavaScriptCore/wtf/text/WTFString.h:92
>  WTF_EXPORT_PRIVATE float charactersToFloat(const UChar*, size_t, bool* ok = 0, bool* didReadNumber = 0);
> +WTF_EXPORT_PRIVATE float charactersToFloatWithJunk(const UChar*, size_t, bool* ok = 0, bool* didReadNumber = 0);

Btw, does the didReadNumber make sense for the non-junk versions?

Comment 4 Mark Hahnenberg 2012-02-16 10:21:10 PST

> Btw, does the didReadNumber make sense for the non-junk versions?
I think it still does in case somebody wants to do some additional parsing based on whether or not the prefix of the string is a number of some sort.

Comment 5 Mark Hahnenberg 2012-02-16 16:54:50 PST

Committed r108001: <http://trac.webkit.org/changeset/108001>