Bug 78774

Summary: Fix the broken viewport tests
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: joepeck, kenneth
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 68044    
Attachments:
Description Flags
Patch
none
Patch kenneth: review+

Mark Hahnenberg
Reported 2012-02-15 19:34:58 PST
The patch for bug 68044 broke a few tests in fast/viewport. We should fix these for the platforms that support them.
Attachments
Patch (8.40 KB, patch)
2012-02-15 19:44 PST, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Patch (9.01 KB, patch)
2012-02-15 21:17 PST, Mark Hahnenberg 		kenneth: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2012-02-15 19:44:25 PST
Created attachment 127298 [details] Patch
Mark Hahnenberg
Comment 2 2012-02-15 21:17:41 PST
Created attachment 127308 [details] Patch
Kenneth Rohde Christiansen
Comment 3 2012-02-16 02:07:53 PST
Comment on attachment 127308 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=127308&action=review > Source/JavaScriptCore/wtf/text/WTFString.h:90 > +WTF_EXPORT_PRIVATE float charactersToFloatWithJunk(const LChar*, size_t, bool* ok = 0, bool* didReadNumber = 0); Maybe charactersToFloatIgnoringJunk would be more descriptive? > Source/JavaScriptCore/wtf/text/WTFString.h:92 > WTF_EXPORT_PRIVATE float charactersToFloat(const UChar*, size_t, bool* ok = 0, bool* didReadNumber = 0); > +WTF_EXPORT_PRIVATE float charactersToFloatWithJunk(const UChar*, size_t, bool* ok = 0, bool* didReadNumber = 0); Btw, does the didReadNumber make sense for the non-junk versions?
Mark Hahnenberg
Comment 4 2012-02-16 10:21:10 PST
> Btw, does the didReadNumber make sense for the non-junk versions? I think it still does in case somebody wants to do some additional parsing based on whether or not the prefix of the string is a number of some sort.
Mark Hahnenberg
Comment 5 2012-02-16 16:54:50 PST
Committed r108001: <http://trac.webkit.org/changeset/108001>
Note You need to log in before you can comment on or make changes to this bug.