Summary: | [BlackBerry] Upstream WebPageGroupLoadDeferrer.{h, cpp} | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Leo Yang <leo.yang> | ||||||
Component: | New Bugs | Assignee: | Leo Yang <leo.yang> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | charles.wei, rwlbuis, staikos, tonikitoo, zimmermann | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 73144 | ||||||||
Attachments: |
|
Description
Leo Yang
2012-02-15 18:36:12 PST
Created attachment 127293 [details]
Patch
Comment on attachment 127293 [details]
Patch
LGTM.
Comment on attachment 127293 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=127293&action=review > Source/WebKit/blackberry/Api/WebPageGroupLoadDeferrer.cpp:32 > + m_pageGroupLoadDeferrer = new WebCore::PageGroupLoadDeferrer(webPage->d->m_page, true); lets add a /*whatIsThisBool*/-like comment. (In reply to comment #3) > (From update of attachment 127293 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=127293&action=review > > > Source/WebKit/blackberry/Api/WebPageGroupLoadDeferrer.cpp:32 > > + m_pageGroupLoadDeferrer = new WebCore::PageGroupLoadDeferrer(webPage->d->m_page, true); > > lets add a /*whatIsThisBool*/-like comment. ok. thanks. Created attachment 127296 [details]
Patch v2
Comment on attachment 127296 [details]
Patch v2
Antonio made a good point, I guess an enum instead of a bool would have helped there. Looks good!
Committed r107873: <http://trac.webkit.org/changeset/107873> |