| Summary: | ENH: Add ability to run subset of JavaScript layout tests with JSC | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Saboff <msaboff> | ||||
| Component: | Tools / Tests | Assignee: | Michael Saboff <msaboff> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ap | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Michael Saboff
2012-02-15 17:28:46 PST
Created attachment 127284 [details]
Proposed patch
Would it be appropriate to just make sure that fast/js is exactly the directory of tests appropriate for run-fast-jsc, and move them accordingly? I'm fairly sure that this used to be the idea. Committed r107997: <http://trac.webkit.org/changeset/107997> (In reply to comment #2) > Would it be appropriate to just make sure that fast/js is exactly the directory of tests appropriate for run-fast-jsc, and move them accordingly? > > I'm fairly sure that this used to be the idea. I think that is achievable. The list of tests in the patch was derived by running all js tests from the command line and excluding those that failed. Some of those failures were due to markup present in output causing mismatch. That is easily fixed. Other tests require or currently use the DOM and these might be harder to coerce to running under jsc. Asynchronous tests would require more changes or might not work at all. Then there are the 20 regex tests. They could be moved to fast/js. Before moving things around, I think it makes sense to see how many of the tests that fail under jsc could be easily made to pass. After that I suspect that we'd have a small list to move. It still makes sense to pass the driver a list as one may want to only run a subset of tests. |