Bug 78759 – REGRESSION (r107836): fast/box-shadow/spread.html and fast/writing-mode/box-shadow-*.html tests failing

• Component: Layout and Rendering
• Status: RESOLVED FIXED

fast/box-shadow/spread.html and fast/writing-mode/box-shadow-*.html tests failing after r107836, the fix for bug 78728.

Created attachment 127276 [details]
Refine checks in boxShadowShouldBeAppliedToBackground()

[Simon Fraser (smfr)]

Comment on attachment 127276 [details]
Refine checks in boxShadowShouldBeAppliedToBackground()

View in context: https://bugs.webkit.org/attachment.cgi?id=127276&action=review

> Source/WebCore/rendering/InlineFlowBox.cpp:1086
> +    return (!hasFillImage && !renderer()->style()->hasBorderRadius()) || (!prevLineBox() && !nextLineBox()) || !parent();

It's hard to understand all the conditions in this line. Perhaps an explanatory comment would help.

> Source/WebCore/rendering/RenderBoxModelObject.cpp:2623
> +    if (lastBackgroundLayer->image() && style()->hasBorderRadius())
> +        return false;
> +
> +    if (inlineFlowBox && !inlineFlowBox->boxShadowCanBeAppliedToBackground(*lastBackgroundLayer))
> +        return false;

Why do we only check the last fill layer?

(In reply to comment #2)
> (From update of attachment 127276 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=127276&action=review
> 
> > Source/WebCore/rendering/InlineFlowBox.cpp:1086
> > +    return (!hasFillImage && !renderer()->style()->hasBorderRadius()) || (!prevLineBox() && !nextLineBox()) || !parent();
> 
> It's hard to understand all the conditions in this line. Perhaps an explanatory comment would help.
> 
> > Source/WebCore/rendering/RenderBoxModelObject.cpp:2623
> > +    if (lastBackgroundLayer->image() && style()->hasBorderRadius())
> > +        return false;
> > +
> > +    if (inlineFlowBox && !inlineFlowBox->boxShadowCanBeAppliedToBackground(*lastBackgroundLayer))
> > +        return false;
> 
> Why do we only check the last fill layer?

That’s the layer that will be casting the shadow, if any.

Committed <http://webkit.org/r107874>.

[David Harrison]

rdar://10915520