Bug 78755
| Summary: | [chromium] REGRESSION(r107836): box shadow test failures | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Tony Chang <tony> |
| Component: | Layout and Rendering | Assignee: | Dana Jansens <danakj> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | danakj, jamesr, noel.gordon |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 78759, 78775, 78859 | ||
| Bug Blocks: | |||
Tony Chang
http://trac.webkit.org/r107836 in bug 78728 was supposed to be a refactoring that improved performance. Some tests had minor changes (I'll rebaseline those), but 3 tests failed in unexpected ways. Those tests are:
- fast/box-shadow/spread.html : the black shapes got smaller
- fast/writing-mode/box-shadow-horizontal-bt.html : the shadow disappeared from the first line of text
- fast/writing-mode/box-shadow-vertical-lr.html : same as above, the shadow disappeared from the first line of text
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Tony Chang
I'm going to mark the three tests as failing while I wait to hear back from mitz.
Tony Chang
fast/writing-mode/box-shadow-vertical-rl.html is also failing in the same way as the other two writing mode box shadow tests.
noel gordon
compositing/culling/scrolled-within-boxshadow.html also regressed, right?
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=compositing%2Fculling%2Fscrolled-within-boxshadow.html
noel gordon
Marked it failing in https://bugs.webkit.org/show_bug.cgi?id=78755
noel gordon
Ahem, marked it failing in http://trac.webkit.org/changeset/107882
Dana Jansens
https://bugs.webkit.org/show_bug.cgi?id=78775 appears to fix all of these. Will re-enable once it lands and they show up green in the dashboard.
Tony Chang
http://trac.webkit.org/changeset/107969 re-enabled the spread and box-shadow-* tests. compositing/culling/scrolled-within-boxshadow.html is still failing. I'll ask mitz about it.
noel gordon
http://trac.webkit.org/changeset/108115 re-enabled compositing/culling/scrolled-within-boxshadow.html