Bug 78743 – [chromium] Background images should be filtered when page is scaled

• Component: New Bugs
• Status: RESOLVED WONTFIX

[Iain Merrick]

[chromium] Background images should be filtered when page is scaled

[Iain Merrick]

Created attachment 127236 [details]
Patch

[Iain Merrick]

This is intended to fix a problem we noticed on Chrome for Android. The resampling calculation wasn't taking page scale into account, so a pinch-zoom would result in ugly moire patterns.

Remaining problems:

Resampling is still disabled because the image is below kSmallImageSizeThreshold. Not sure what to do about that. The comment suggests it's mainly for images stretched out to lines, but I have a tiny image tiled onto a large rectangle. I could just make the image larger, but that won't fix any real sites!

Also, if we skip the kSmallImageSizeThreshold, we end up with RESAMPLE_AWESOME, but I think we actually want RESAMPLE_LINEAR in this case.

Maybe kill two birds with one stone, and return RESAMPLE_LINEAR instead of RESAMPLE_NONE for tiny images? Not sure if that would be bad for performance.

[Adam Barth]

The text you've written in Comment #2 is good information to include in the ChangeLog.

[Iain Merrick]

In offline discussion with Stephen, we decided to just make the test image bigger to avoid the kSmallImageSizeThreshold, as it looks like most real sites use larger images anyway. I'll go ahead and do that.

[Adam Barth]

Comment on attachment 127236 [details]
Patch

This looks fine, but please add the information from Comment #2 to the ChangeLog.

[Iain Merrick]

Created attachment 127267 [details]
Fixed kSmallImageSizeThreshold, updated ChangeLog

[Iain Merrick]

Created attachment 127268 [details]
Rebaselined test result

[Iain Merrick]

Comment on attachment 127268 [details]
Rebaselined test result

Removing cq+, gardener asked me to fix the test expectations for other platforms.

[Iain Merrick]

Created attachment 127272 [details]
Add test_expectations for other platforms

[Iain Merrick]

Comment on attachment 127272 [details]
Add test_expectations for other platforms

Sorry for the extra patches, this is my first pixel test!

[Daniel Sievers]

You might also find the discussion in this bug interesting:
https://bugs.webkit.org/show_bug.cgi?id=72073

(In reply to comment #10)
> (From update of attachment 127272 [details])
> Sorry for the extra patches, this is my first pixel test!

[WebKit Review Bot]

Comment on attachment 127272 [details]
Add test_expectations for other platforms

Attachment 127272 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11529888

New failing tests:
fast/images/background-image-zoomed-out.html
fast/borders/border-image-rotate-transform.html
fast/borders/inline-mask-overlay-image-outset-vertical-rl.html
fast/backgrounds/background-position-parsing.html
fast/borders/border-image-side-reduction.html
fast/speech/input-appearance-searchandspeech.html
fast/borders/border-image-scale-transform.html
svg/custom/image-small-width-height.svg
svg/custom/convolution-crash.svg
fast/forms/input-appearance-height.html
fast/forms/search-vertical-alignment.html
fast/borders/inline-mask-overlay-image-outset.html

[WebKit Review Bot]

Attachment 127236 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9

Updating OpenSource
From git://git.webkit.org/WebKit
   05fb97d..85635f0  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 107897 = 05fb97d0fc2d24b504eb2c45dda5211bb467c1b0
r107898 = f6c3de1a05bd9c4fff925d93ec13471153872f6e
r107899 = 85635f0c2041419d71726ff0e99c8c93b104fe01
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Applying: dataTransfer.types (HTML5 drag & drop) should return DOMStringList
Using index info to reconstruct a base tree...
<stdin>:84: trailing whitespace.
        
<stdin>:333: trailing whitespace.
<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"
<stdin>:334: trailing whitespace.
 width="300" height="300" onload="runRepaintTest()">
<stdin>:335: trailing whitespace.
<script xlink:href="../../fast/repaint/resources/repaint.js" />
<stdin>:336: trailing whitespace.
<script><![CDATA[
warning: squelched 16 whitespace errors
warning: 21 lines add whitespace errors.
Falling back to patching base and 3-way merge...
Auto-merging LayoutTests/ChangeLog
Auto-merging Source/WebCore/ChangeLog
CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog
Failed to merge in the changes.
Patch failed at 0001 dataTransfer.types (HTML5 drag & drop) should return DOMStringList

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 164.


If any of these errors are false positives, please file a bug against check-webkit-style.

[Iain Merrick]

The only layout test failure that looks relevant is compositing/culling/scrolled-within-boxshadow.html, and it's passing locally, so I'll give this another try in the commit queue.

[Iain Merrick]

Created attachment 127425 [details]
Fixed rebase conflicts

[Daniel Sievers]

If we are doing this for drawPattern, shouldn't https://bugs.webkit.org/show_bug.cgi?id=72073 land also then, which does the similar thing for the normal draw path?

[Iain Merrick]

Sorry, I meant to comment on that bug too. Yes, definitely, we're doing the same thing for two different code paths.

[WebKit Review Bot]

Attachment 127267 [details] did not pass style-queue:

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=127267&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=78743&ctype=xml
Processing 1 patch from 1 bug.
Processing patch 127267 from bug 78743.
Failed to run "[u'/mnt/git/webkit-style-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-style-queue/

Last 500 characters of output:

Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/platform/graphics/skia/ImageSkia.cpp
Hunk #1 FAILED at 107.
Hunk #2 FAILED at 322.
Hunk #3 FAILED at 334.
3 out of 3 hunks FAILED -- saving rejects to file Source/WebCore/platform/graphics/skia/ImageSkia.cpp.rej
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/fast/images/background-image-zoomed-out-expected.txt
patching file LayoutTests/fast/images/background-image-zoomed-out.html

Failed to run "[u'/mnt/git/webkit-style-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-style-queue/


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Review Bot]

Comment on attachment 127425 [details]
Fixed rebase conflicts

Rejecting attachment 127425 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
m/gtk/test_expectations.txt
Hunk #1 FAILED at 100.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/gtk/test_expectations.txt.rej
patching file LayoutTests/platform/mac/test_expectations.txt
Hunk #1 FAILED at 203.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/mac/test_expectations.txt.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/11603503

[Iain Merrick]

Created attachment 128614 [details]
Fixed rebase conflicts

[WebKit Review Bot]

Comment on attachment 128614 [details]
Fixed rebase conflicts

Attachment 128614 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11574631

New failing tests:
tables/mozilla/bugs/bug4427.html
fast/borders/inline-mask-overlay-image-outset-vertical-rl.html
fast/borders/inline-mask-overlay-image-outset.html
fast/backgrounds/background-position-parsing.html
fast/borders/border-image-side-reduction.html
tables/mozilla/core/bloomberg.html
fast/speech/input-appearance-searchandspeech.html
tables/mozilla/bugs/bug1430.html
fast/borders/border-image-scale-transform.html
svg/custom/image-small-width-height.svg
svg/custom/convolution-crash.svg
fast/forms/input-appearance-height.html
tables/mozilla/bugs/bug4093.html
tables/mozilla/bugs/bug625.html
tables/mozilla/bugs/bug1296.html
fast/forms/search-vertical-alignment.html

[WebKit Commit Bot]

Attachment 128614 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1
Traceback (most recent call last):
  File "Tools/Scripts/check-webkit-style", line 48, in <module>
    sys.exit(CheckWebKitStyle().main())
  File "/Users/abarth/git/webkit-queue/Tools/Scripts/webkitpy/style/main.py", line 154, in main
    patch_checker.check(patch)
  File "/Users/abarth/git/webkit-queue/Tools/Scripts/webkitpy/style/patchreader.py", line 66, in check
    self._text_file_reader.process_file(file_path=path, line_numbers=line_numbers)
  File "/Users/abarth/git/webkit-queue/Tools/Scripts/webkitpy/style/filereader.py", line 130, in process_file
    self._processor.process(lines, file_path, **kwargs)
  File "/Users/abarth/git/webkit-queue/Tools/Scripts/webkitpy/style/checker.py", line 838, in process
    checker.check(lines)
  File "/Users/abarth/git/webkit-queue/Tools/Scripts/webkitpy/style/checkers/test_expectations.py", line 103, in check
    overrides = self._port_obj.test_expectations_overrides()
AttributeError: 'NoneType' object has no attribute 'test_expectations_overrides'


If any of these errors are false positives, please file a bug against check-webkit-style.

[Stephen Chenney]

Comment on attachment 128614 [details]
Fixed rebase conflicts

https://code.google.com/p/chromium/issues/detail?id=231283