Bug 78703

Summary:

Add script to determine which functions are affected by a patch

Product:

WebKit

Reporter:

Csaba Osztrogonác <ossy>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

ossy

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

78707

Attachments:

Description	Flags
Patch	darin: review-
Patch v2	abarth: review-

Description Csaba Osztrogonác 2012-02-15 05:31:26 PST

It is needed for selective testing.

Comment 1 Nandor Huszka 2012-02-15 06:56:23 PST

Created attachment 127177 [details]
Patch

Determines the functions names with the help of prepare-ChangeLog.

Comment 2 Darin Adler 2012-02-15 10:00:48 PST

Comment on attachment 127177 [details]
Patch

The idea of this script seems fine. The name “generate functions” seems totally wrong though, since the script that does not generate functions. Maybe a name like “list modified functions”?

Comment 3 Nandor Huszka 2012-02-16 02:33:21 PST

Created attachment 127335 [details]
Patch v2

(In reply to comment #10)
Thank you for the comment, I have renamed it.

Comment 4 Adam Barth 2012-02-24 10:41:51 PST

Comment on attachment 127335 [details]
Patch v2

Why do we need a separate script for this?  If you're planning to use this in webkitpy, we already have a function called changed_files which does this work.

Comment 5 Csaba Osztrogonác 2012-11-22 03:49:16 PST

You're right, we don't need separated script for this.