Bug 78703

Summary: Add script to determine which functions are affected by a patch
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WONTFIX    
Severity: Normal CC: ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 78707    
Attachments:
Description Flags
Patch
darin: review-
Patch v2 abarth: review-

Csaba Osztrogonác
Reported 2012-02-15 05:31:26 PST
It is needed for selective testing.
Attachments
Patch (2.29 KB, patch)
2012-02-15 06:56 PST, Nandor Huszka 		darin: review-
DetailsFormatted DiffDiff
Patch v2 (2.30 KB, patch)
2012-02-16 02:33 PST, Nandor Huszka 		abarth: review-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nandor Huszka
Comment 1 2012-02-15 06:56:23 PST
Created attachment 127177 [details] Patch Determines the functions names with the help of prepare-ChangeLog.
Darin Adler
Comment 2 2012-02-15 10:00:48 PST
Comment on attachment 127177 [details] Patch The idea of this script seems fine. The name “generate functions” seems totally wrong though, since the script that does not generate functions. Maybe a name like “list modified functions”?
Nandor Huszka
Comment 3 2012-02-16 02:33:21 PST
Created attachment 127335 [details] Patch v2 (In reply to comment #10) Thank you for the comment, I have renamed it.
Adam Barth
Comment 4 2012-02-24 10:41:51 PST
Comment on attachment 127335 [details] Patch v2 Why do we need a separate script for this? If you're planning to use this in webkitpy, we already have a function called changed_files which does this work.
Csaba Osztrogonác
Comment 5 2012-11-22 03:49:16 PST
You're right, we don't need separated script for this.
Note You need to log in before you can comment on or make changes to this bug.