| Summary: | [Qt] Move Qt platform specific GL Context/Surface creation out of WebCore into WebKit | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Hausmann <hausmann> | ||||
| Component: | New Bugs | Assignee: | Simon Hausmann <hausmann> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | gustavo, noam, webkit.review.bot, xan.lopez | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | 78690 | ||||||
| Bug Blocks: | 78109, 78694 | ||||||
| Attachments: |
|
||||||
|
Description
Simon Hausmann
2012-02-15 03:55:48 PST
Created attachment 127160 [details]
[Qt] Move Qt platform specific GL Context/Surface creation out of WebCore into WebKit
Attachment 127160 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebKit/qt/WebCoreSupport/PageClientQt.h:101: The parameter name "context" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/PageClientQt.h:102: The parameter name "surface" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/PageClientQt.h:207: The parameter name "context" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/PageClientQt.h:208: The parameter name "surface" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/platform/qt/QWebPageClient.h:103: The parameter name "context" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/platform/qt/QWebPageClient.h:104: The parameter name "surface" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 6 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 127160 [details] [Qt] Move Qt platform specific GL Context/Surface creation out of WebCore into WebKit Attachment 127160 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11522732 Landed with style issues fixed Committed r107815: <http://trac.webkit.org/changeset/107815> |