Bug 78692 - [Qt] Move Qt platform specific GL Context/Surface creation out of WebCore into WebKit
Summary: [Qt] Move Qt platform specific GL Context/Surface creation out of WebCore int...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Hausmann
URL:
Keywords:
Depends on: 78690
Blocks: 78109 78694
  Show dependency treegraph
 
Reported: 2012-02-15 03:55 PST by Simon Hausmann
Modified: 2012-02-15 07:36 PST (History)
4 users (show)

See Also:


Attachments
[Qt] Move Qt platform specific GL Context/Surface creation out of WebCore into WebKit (12.12 KB, patch)
2012-02-15 04:36 PST, Simon Hausmann
noam: review+
gns: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Hausmann 2012-02-15 03:55:48 PST
[Qt] Move Qt platform specific GL Context/Surface creation out of WebCore into WebKit
Comment 1 Simon Hausmann 2012-02-15 04:36:27 PST
Created attachment 127160 [details]
[Qt] Move Qt platform specific GL Context/Surface creation out of WebCore into WebKit
Comment 2 WebKit Review Bot 2012-02-15 05:02:51 PST
Attachment 127160 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebKit/qt/WebCoreSupport/PageClientQt.h:101:  The parameter name "context" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/PageClientQt.h:102:  The parameter name "surface" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/PageClientQt.h:207:  The parameter name "context" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/PageClientQt.h:208:  The parameter name "surface" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/qt/QWebPageClient.h:103:  The parameter name "context" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/qt/QWebPageClient.h:104:  The parameter name "surface" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 6 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Gustavo Noronha (kov) 2012-02-15 06:07:31 PST
Comment on attachment 127160 [details]
[Qt] Move Qt platform specific GL Context/Surface creation out of WebCore into WebKit

Attachment 127160 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/11522732
Comment 4 Simon Hausmann 2012-02-15 07:36:11 PST
Landed with style issues fixed

Committed r107815: <http://trac.webkit.org/changeset/107815>