Bug 78687 – [Qt] Unskip compositing & 3d-rendering tests

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Noam Rosenthal]

We're currently skipping all the compositing and 3d-rendering tests, even though most of them work. We should unskip the ones that work, and put real comments about the ones that don't.

[Rafael Brandao]

Created attachment 127391 [details]
Patch

This is a work in progress. I still need to file new bugs for these still skipped tests, and check if all expected results we have so far are really what we should expect.

[Rafael Brandao]

(In reply to comment #1)
> Created an attachment (id=127391) [details]
> Patch
> 
> This is a work in progress. I still need to file new bugs for these still skipped tests, and check if all expected results we have so far are really what we should expect.

The tests were run with 'run-layout-tests --pixel-tests -2 --enable-hardware-gpu --accelerated-painting --repeat-each=10 compositing'.

[Rafael Brandao]

Created attachment 128751 [details]
Patch

Still needs to upgrade qt5 with today's hash and see if we get any difference. It has been a lot of work to figure out which tests are really running as they should, but I believe it is very close now.

[Rafael Brandao]

Created attachment 129133 [details]
Patch

I believe this is in a good shape now, but I couldn't skip transforms/3d as we are not doing any transformation there. I've left a few comments on qt5-wk2 skipped list describing the issues I've found.

[Noam Rosenthal]

Comment on attachment 129133 [details]
Patch

LGTM
Will let you commit :)

[Rafael Brandao]

Ossy, could you double check if this patch will make bots cry and give it a cq+?

[Csaba Osztrogonác]

Comment on attachment 129133 [details]
Patch

double checked, cq+

[Csaba Osztrogonác]

(In reply to comment #2)
> The tests were run with 'run-layout-tests --pixel-tests -2 --enable-hardware-gpu --accelerated-painting --repeat-each=10 compositing'.

I think --enable-hardware-gpu and --accelerated-painting are supported only by Chromium DRT.

[WebKit Review Bot]

The commit-queue encountered the following flaky tests while processing attachment 129133 [details]:

css3/filters/effect-contrast-hw.html bug 79618 (author: [e-mail])
perf/object-keys.html bug 63769 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Review Bot]

Comment on attachment 129133 [details]
Patch

Rejecting attachment 129133 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ommit-queue/Source/WebKit/chromium/third_party/snappy/src --revision 37 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
46>At revision 37.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/11714050

[Rafael Brandao]

(In reply to comment #8)
> (In reply to comment #2)
> > The tests were run with 'run-layout-tests --pixel-tests -2 --enable-hardware-gpu --accelerated-painting --repeat-each=10 compositing'.
> 
> I think --enable-hardware-gpu and --accelerated-painting are supported only by Chromium DRT.

No problem. I've removed those before submitting this patch, the tests were run with the same command as build bot. Thanks for looking into it.

[Rafael Brandao]

Created attachment 129339 [details]
Patch

Trying it again (rebased patch).

[Noam Rosenthal]

Comment on attachment 129339 [details]
Patch

You don't need to set the r? flag if it's already reviewed :)

[WebKit Review Bot]

Comment on attachment 129339 [details]
Patch

Clearing flags on attachment: 129339

Committed r109167: <http://trac.webkit.org/changeset/109167>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.