Bug 78669 – [EFL] Check the tile's zoom factor before rendering.

• Component: WebKit EFL
• Status: RESOLVED INVALID

[JungJik Lee]

It needs to check the zoom factor of the tile before drawing the tile.
At the current code, the rendering function only checks the tile's width and height.

[JungJik Lee]

Created attachment 127119 [details]
proposal patch

[Gyuyoung Kim]

Comment on attachment 127119 [details]
proposal patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127119&action=review

> Source/WebKit/efl/ChangeLog:9
> +        Before rendering the tile, it needs to check the zoom factor too.

I think you need to mention why zoom factor needs to be checked as well.

[JungJik Lee]

(In reply to comment #2)
> (From update of attachment 127119 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=127119&action=review
> 
> > Source/WebKit/efl/ChangeLog:9
> > +        Before rendering the tile, it needs to check the zoom factor too.
> 
> I think you need to mention why zoom factor needs to be checked as well.

After merging this patch(http://wkb.ug/68595), we manages the matrices which have each different zoom factors. So the tiles in different zoom level's matrix can be rendered.

[Gyuyoung Kim]

Comment on attachment 127119 [details]
proposal patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127119&action=review

>>> Source/WebKit/efl/ChangeLog:9
>>> +        Before rendering the tile, it needs to check the zoom factor too.
>> 
>> I think you need to mention why zoom factor needs to be checked as well.
> 
> After merging this patch(http://wkb.ug/68595), we manages the matrices which have each different zoom factors. So the tiles in different zoom level's matrix can be rendered.

I mean it is better to write above reason to ChangeLog.

[JungJik Lee]

Created attachment 127129 [details]
revised_patch_1

[Gyuyoung Kim]

Comment on attachment 127129 [details]
revised_patch_1

LGTM.

[KwangHyuk]

> Source/WebKit/efl/ewk/ewk_tiled_backing_store.cpp:609
> +    if (priv->view.tile.zoom != tile->zoom || priv->view.tile.width != tile->width || priv->view.tile.height != tile->height)

For the patch, it might be started from assumption. so, I would like to see the test scenario or clue about issue ?
On the other hand, I suggest you to check whether you can remove "priv->view.tile.width != tile->width || priv->view.tile.height != tile->height" because there was no api to change tile size at runtime.

[JungJik Lee]

To KwangHyuk, as you know this, it was an internal issue.
So that I made this patch but it does not occur anymore in both open source and internal project. I'll change this patch's flag to invalid. In addition, I think it is better to remove the line later with other useless code.