Bug 78640

Summary: NRWT is broken for the default port
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch tony: review+

Dirk Pranke
Reported 2012-02-14 15:04:55 PST
NRWT is broken for the default port
Attachments
Patch (1.89 KB, patch)
2012-02-14 15:09 PST, Dirk Pranke 		tony: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2012-02-14 15:09:25 PST
Created attachment 127054 [details] Patch
Tony Chang
Comment 2 2012-02-14 15:11:25 PST
Comment on attachment 127054 [details] Patch Can you add a unit test that passes self._options that matches what's passed in by the default port? Or just passes in self._options.platform.
Dirk Pranke
Comment 3 2012-02-14 15:17:09 PST
(In reply to comment #2) > (From update of attachment 127054 [details]) > Can you add a unit test that passes self._options that matches what's passed in by the default port? Or just passes in self._options.platform. Yeah, although it'll be a little bit ugly, so I'll add that as a separate patch on a separate bug to not hold this up or confuse it.
Dirk Pranke
Comment 4 2012-02-14 15:20:37 PST
Committed r107746: <http://trac.webkit.org/changeset/107746>
Note You need to log in before you can comment on or make changes to this bug.