Bug 78635

Summary: [UNIX] Plugin information fields are not interpreted as UTF-8
Product: WebKit Reporter: Diego Escalante Urrelo <diegoe>
Component: WebKitGTKAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, kling, mrobinson, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Diego Escalante Urrelo
Reported 2012-02-14 14:38:52 PST
Concrete test case: totem plugin for DiVX is named: DivX® Web Player But WebKitGTK+ reads it like this: DivX® Web Player The original string in totem source is: browser-plugin/totemPlugin.cpp: =8<======= static const char kPluginDescription[] = #elif defined(TOTEM_MULLY_PLUGIN) "DivX\xC2\xAE Web Player"; =8<======= The value is handled to WebKitGTK+ by the GetValue implementation here: browser-plugin/totemPluginGlue.cpp: =8<======= static NPError totem_plugin_get_value (NPP instance, NPPVariable variable, void *value) case NPPVpluginNameString: *((char **)value) = totemPlugin::PluginDescription (); break; =8<=======
Attachments
Patch (10.34 KB, patch)
2012-02-17 20:38 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2012-02-17 20:31:09 PST
This appears to be a problem with all Unixy-non-Chromium ports.
Martin Robinson
Comment 2 2012-02-17 20:38:52 PST
Created attachment 127690 [details] Patch
Gustavo Noronha (kov)
Comment 3 2012-02-20 17:56:27 PST
Comment on attachment 127690 [details] Patch Makes sense. Diego will be happy!
WebKit Review Bot
Comment 4 2012-02-20 18:19:21 PST
Comment on attachment 127690 [details] Patch Clearing flags on attachment: 127690 Committed r108281: <http://trac.webkit.org/changeset/108281>
WebKit Review Bot
Comment 5 2012-02-20 18:19:26 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.