Summary: | REGRESSION: New text field doesn't recognize the read only attribute | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Petersen <c.petersen87> | ||||||||
Component: | Forms | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Major | Keywords: | InRadar, Regression | ||||||||
Priority: | P1 | ||||||||||
Version: | 420+ | ||||||||||
Hardware: | Mac | ||||||||||
OS: | OS X 10.4 | ||||||||||
Attachments: |
|
Description
Chris Petersen
2006-03-19 07:51:04 PST
Created attachment 7173 [details]
Sample test case that uses readonly attribute
This issue has been filed in Radar as <rdar://problem/4483359> Bumping to P1 since this causes a text field regression Created attachment 7414 [details]
Patch to fix test case
Comment on attachment 7414 [details]
Patch to fix test case
Does this handle dynamic updates to the readonly attribute correctly? Make sure to test that. I'm not sure if it will. The change needs to happen after style attached to be an effective test, so maybe a button on the side to toggle readonly-ness.
When you do land this, make sure to land the test case as well.
(In reply to comment #5) > (From update of attachment 7414 [details] [edit]) > Does this handle dynamic updates to the readonly attribute correctly? Make sure > to test that. I'm not sure if it will. Yes, dynamic updates to the readonly property work just fine. This is because we reflect the element's changes in updateFromElement(). This is how the old text field worked. Comment on attachment 7414 [details]
Patch to fix test case
Use READ_WRITE_PLAINTEXT_ONLY instead of READ_WRITE
Created attachment 7421 [details]
Patch to only allow plain text; also fixed assertion
Comment on attachment 7421 [details]
Patch to only allow plain text; also fixed assertion
r=me. thanks tim!
Fix landed to TOT, revision 13617. |