Bug 7858

Summary:

REGRESSION: New text field doesn't recognize the read only attribute

Product:

WebKit

Reporter:

Chris Petersen <c.petersen87>

Component:

Forms

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Major

Keywords:

InRadar, Regression

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
Sample test case that uses readonly attribute	none
Patch to fix test case	adele: review-
Patch to only allow plain text; also fixed assertion	adele: review+

Chris Petersen

Reported 2006-03-19 07:51:04 PST

New text input fields ignore the read only attribute. When this attribute is specified, the input field can't be edited. However with a new text field, I can edit it even when this attribute is enabled.

Attachments
Sample test case that uses readonly attribute (261 bytes, text/html) 2006-03-19 07:52 PST, Chris Petersen	no flags	Details
Patch to fix test case (1.62 KB, patch) 2006-03-31 01:31 PST, Tim Omernick	adele: review-	Details Formatted Diff Diff
Patch to only allow plain text; also fixed assertion (5.08 KB, patch) 2006-03-31 12:52 PST, Tim Omernick	adele: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Chris Petersen

Comment 1 2006-03-19 07:52:08 PST

Created attachment 7173 [details] Sample test case that uses readonly attribute

Chris Petersen

Comment 2 2006-03-19 08:36:18 PST

This issue has been filed in Radar as <rdar://problem/4483359>

Adele Peterson

Comment 3 2006-03-29 17:51:54 PST

Bumping to P1 since this causes a text field regression

Tim Omernick

Comment 4 2006-03-31 01:31:40 PST

Created attachment 7414 [details] Patch to fix test case

Maciej Stachowiak

Comment 5 2006-03-31 03:04:37 PST

Comment on attachment 7414 [details] Patch to fix test case Does this handle dynamic updates to the readonly attribute correctly? Make sure to test that. I'm not sure if it will. The change needs to happen after style attached to be an effective test, so maybe a button on the side to toggle readonly-ness. When you do land this, make sure to land the test case as well.

Tim Omernick

Comment 6 2006-03-31 10:04:42 PST

(In reply to comment #5) > (From update of attachment 7414 [details] [edit]) > Does this handle dynamic updates to the readonly attribute correctly? Make sure > to test that. I'm not sure if it will. Yes, dynamic updates to the readonly property work just fine. This is because we reflect the element's changes in updateFromElement(). This is how the old text field worked.

Adele Peterson

Comment 7 2006-03-31 11:01:16 PST

Comment on attachment 7414 [details] Patch to fix test case Use READ_WRITE_PLAINTEXT_ONLY instead of READ_WRITE

Tim Omernick

Comment 8 2006-03-31 12:52:08 PST

Created attachment 7421 [details] Patch to only allow plain text; also fixed assertion

Adele Peterson

Comment 9 2006-03-31 12:53:45 PST

Comment on attachment 7421 [details] Patch to only allow plain text; also fixed assertion r=me. thanks tim!

Tim Omernick

Comment 10 2006-03-31 12:55:41 PST

Fix landed to TOT, revision 13617.

Note You need to log in before you can comment on or make changes to this bug.