Bug 78578 – There is no complete test cases of optional arguments for MediaStream API and PeerConnection

• Component: WebCore JavaScript
• Status: RESOLVED FIXED

[Yanbin]

There are only some tests on  /third_party/WebKit/LaoutTests/fast/mediastreams to testing optional argument for addstream function . It only don't cover all possible input parameters scenarios and other functions defined on http://www.w3.org/TR/webrtc/.
I will deliver a new patch for those test cases definition.

[Yanbin]

Created attachment 127111 [details]
Patch

Patch

[Tommy Widenflycht]

Hmm, it seems that the patch didn't upload correctly.
Did you use "Tools/Scripts/webkit-patch upload"?

[Yanbin]

Created attachment 127288 [details]
Patch

updated patch

[Adam Barth]

Comment on attachment 127288 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127288&action=review

> LayoutTests/ChangeLog:4
> + 2012-02-16  Yanbin Zhang  <[e-mail]>
> +     There is no complete test cases of optional arguments for MediaStream API and PeerConnection
> +     https://bugs.webkit.org/show_bug.cgi?id=78578
> +     

It looks like you've got a slight formatting error in your ChangeLog.  I can correct it for you when landing this patch.

[Yanbin]

Many thanks Adam

[WebKit Review Bot]

Comment on attachment 127288 [details]
Patch

Attachment 127288 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11542993

New failing tests:
fast/mediastream/peerconnection-Attributes.html

[Yanbin]

Created attachment 127798 [details]
new patch


Updated patch for command #6.
For failure of command #6, because some test cases for ICE State defined at http://www.w3.org/TR/webrtc/ were run . It seem those features don't implemented now. 
FAIL pc.ICE_GATHERING == 0x100  should be true. Was false.
FAIL pc.ICE_WAITING == 0x200 should be true. Was false.
FAIL pc.ICE_CHECKING == 0x300 should be true. Was false.
FAIL pc.ICE_CONNECTED == 0x400 should be true. Was false.
FAIL pc.ICE_COMPLETED == 0x500 should be true. Was false.
FAIL pc.ICE_FAILED == 0x600 should be true. Was false.
FAIL pc.ICE_CLOSED == 0x700 should be true. Was false.
FAIL pc.SDP_IDLE == 0x1000 should be true. Was false.
FAIL pc.SDP_WAITING == 0x2000 should be true. Was false.
FAIL pc.SDP_GLARE ==0x3000 should be true. Was false.

test results for those test cases at peerconnection-Attributes-expected.txt file have been modified to FAIL .

[Adam Barth]

Comment on attachment 127798 [details]
new patch

I'll fix the ChangeLog formatting for you.  In general, prepare-ChangeLog should give you the right formatting.

[Adam Barth]

Created attachment 127903 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 127903 [details]
Patch for landing

Clearing flags on attachment: 127903

Committed r108299: <http://trac.webkit.org/changeset/108299>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.