Bug 78568

Summary: webkitpy: clean up options, port handling in manager_worker_broker
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ojan, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 78171    
Attachments:
Description Flags
Patch
none
patch for landing none

Dirk Pranke
Reported 2012-02-13 19:33:27 PST
webkitpy: clean up options, port handling in manager_worker_broker
Attachments
Patch (16.01 KB, patch)
2012-02-13 19:35 PST, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
patch for landing (15.88 KB, patch)
2012-02-14 16:33 PST, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2012-02-13 19:35:29 PST
Created attachment 126891 [details] Patch
Dirk Pranke
Comment 2 2012-02-13 19:36:03 PST
Tony, please take a look (after 78171)?
Tony Chang
Comment 3 2012-02-14 16:13:53 PST
Comment on attachment 126891 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126891&action=review > Tools/ChangeLog:14 > + * Scripts/webkitpy/layout_tests/controllers/manager.py: > + (Manager._run_tests): > + * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py: > + (get): Nit: Some annotations would have made this clearer. Part of this patch is removing unused functions/parameters. Some of it is moving around whether we pass a parameter to a constructor or to a specific method.
Dirk Pranke
Comment 4 2012-02-14 16:18:33 PST
(In reply to comment #3) > Nit: Some annotations would have made this clearer. Part of this patch is removing unused functions/parameters. Some of it is moving around whether we pass a parameter to a constructor or to a specific method. Sorry, I've never been in the habit of function-level annotations in the ChangeLogs (they're always noise to me). I will try to be better about such things in the future.
Dirk Pranke
Comment 5 2012-02-14 16:33:51 PST
Created attachment 127076 [details] patch for landing
Dirk Pranke
Comment 6 2012-02-14 16:36:35 PST
Committed r107754: <http://trac.webkit.org/changeset/107754>
Note You need to log in before you can comment on or make changes to this bug.