Bug 78566

Summary: [CMake] Merge WebKitEfl.cmake into FindEFL.cmake.
Product: WebKit Reporter: Raphael Kubo da Costa (:rakuco) <rakuco>
Component: New BugsAssignee: Raphael Kubo da Costa (:rakuco) <rakuco>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Raphael Kubo da Costa (:rakuco)
Reported 2012-02-13 19:25:26 PST
[CMake] Merge WebKitEfl.cmake into FindEFL.cmake.
Attachments
Patch (3.65 KB, patch)
2012-02-13 19:26 PST, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.63 KB, patch)
2012-02-14 15:25 PST, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Raphael Kubo da Costa (:rakuco)
Comment 1 2012-02-13 19:26:18 PST
Created attachment 126890 [details] Patch
Daniel Bates
Comment 2 2012-02-14 15:16:02 PST
Comment on attachment 126890 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126890&action=review > Source/cmake/FindEFL.cmake:19 > + MESSAGE(FATAL_ERROR "edje_cc could not be found") Nit: Should there be a space between MESSAGE and '('? We seem to be inconsistent throughout the CMake build system with respect to our function call notation.
Raphael Kubo da Costa (:rakuco)
Comment 3 2012-02-14 15:25:18 PST
Created attachment 127056 [details] Patch for landing
Raphael Kubo da Costa (:rakuco)
Comment 4 2012-02-14 15:26:36 PST
Committed r107747: <http://trac.webkit.org/changeset/107747>
Note You need to log in before you can comment on or make changes to this bug.