Bug 78552
| Summary: | SharedBuffer's Vector<RetainPtr<CFDataRef> > should have a typedef | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Benjamin Poulain <benjamin> |
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED CONFIGURATION CHANGED | ||
| Severity: | Normal | CC: | benjamin, ddkilzer |
| Priority: | P2 | Keywords: | EasyFix |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Benjamin Poulain
From https://bugs.webkit.org/show_bug.cgi?id=77718
> Source/WebCore/platform/cf/SharedBufferCF.cpp:121
> + Vector<RetainPtr<CFDataRef> >::const_iterator end = m_dataArray.end();
Nit: Might be nice to have a typedef for Vector<RetainPtr<CFDataRef> >.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
David Kilzer (:ddkilzer)
SharedBufferCF.cpp no longer has this code, and the only data structure it iterates over:
mutable DataSegmentVector m_segments;
Already has the equivalent of a typedef:
using DataSegmentVector = Vector<DataSegmentVectorEntry, 1>;
DataSegmentVector::const_iterator begin() const { return m_segments.begin(); }
DataSegmentVector::const_iterator end() const { return m_segments.end(); }
So moving to RESOLVED/CONFIGURATION CHANGED.