Bug 78544

Summary:

fast/text/atsui-multiple-renderers.html and related report IMAGE failure on commit queue

Product:

WebKit

Reporter:

noel gordon <noel.gordon>

Component:

Tools / Tests

Assignee:

noel gordon <noel.gordon>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, adamk, tony

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

noel gordon

Reported 2012-02-13 15:18:18 PST

Regressions: Unexpected image mismatch : (5) fast/text/atsui-multiple-renderers.html = IMAGE fast/text/international/danda-space.html = IMAGE fast/text/international/thai-baht-space.html = IMAGE fast/text/international/thai-line-breaks.html = IMAGE platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html = IMAGE I have seen those same results for over 4 months, and they seem to slow down the commit queue. We should just add the expected failures until someone who cares/knows about Thai and Atsui rendering cares to investigate.

Attachments
Patch (3.55 KB, patch) 2012-02-13 15:37 PST, noel gordon	no flags	Details Formatted Diff Diff
Patch (3.38 KB, patch) 2012-02-13 16:15 PST, noel gordon	no flags	Details Formatted Diff Diff
Patch (3.36 KB, patch) 2012-02-13 19:04 PST, noel gordon	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

noel gordon

Comment 1 2012-02-13 15:37:02 PST

Created attachment 126849 [details] Patch

noel gordon

Comment 2 2012-02-13 16:09:04 PST

Tests PASS locally for me on linux. Suspect the commit queue does not have the expected fonts installed.

noel gordon

Comment 3 2012-02-13 16:10:20 PST

Mark the tests: PASS (local) + IMAGE+TEXT (commit-queue)

noel gordon

Comment 4 2012-02-13 16:15:55 PST

Created attachment 126858 [details] Patch

noel gordon

Comment 5 2012-02-13 19:04:24 PST

Created attachment 126886 [details] Patch

noel gordon

Comment 6 2012-02-13 19:56:58 PST

(In reply to comment #5) > Created an attachment (id=126886) [details] > Patch Ahem, Mark the tests: PASS (local) + IMAGE+TEXT (commit-queue) + IMAGE (commit-queue)

noel gordon

Comment 7 2012-02-13 20:38:21 PST

Comment on attachment 126886 [details] Patch Clearing flags on attachment: 126886 Committed r107664: <http://trac.webkit.org/changeset/107664>

noel gordon

Comment 8 2012-02-13 20:38:28 PST

All reviewed patches have been landed. Closing bug.

noel gordon

Comment 9 2012-03-07 21:39:00 PST

After http://trac.webkit.org/changeset/109793, commit queue and linux EWS are again reporting platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html = IMAGE

noel gordon

Comment 10 2012-03-07 21:50:31 PST

After http://trac.webkit.org/changeset/109420, commit queue and linux EWS are again reporting fast/text/international/thai-line-breaks.html = IMAGE

Tony Chang

Comment 11 2012-03-08 10:20:06 PST

This patch is wrong. These tests should not be in test_expectations.txt. The ews bots are running a different version of Ubuntu than developers and the waterfall bots. We want the baselines and expectations to reflect what developers and the waterfall bots run. It's not a problem that these fail on the ews bots since they are smart enough to ignore these consistent failures. This problem will go away once we switch to Ubuntu Precise in April/May.

noel gordon

Comment 12 2012-08-07 00:09:45 PDT

Fixed by moving to compute engine.

Note You need to log in before you can comment on or make changes to this bug.