Bug 78540

Summary: Upstream Android's support for SK_B32_SHIFT to JPEGImageEncoder
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, noel.gordon, satish, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Eric Seidel (no email)
Reported 2012-02-13 14:39:38 PST
Upstream Android's support for SK_B32_SHIFT to JPEGImageEncoder
Attachments
Patch (1.41 KB, patch)
2012-02-13 14:40 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2012-02-13 14:40:18 PST
Created attachment 126839 [details] Patch
Eric Seidel (no email)
Comment 2 2012-02-13 14:41:17 PST
Someone with familiarity of Skia and the JPEGEncoder should look at this and make sure it's sane.
Adam Barth
Comment 3 2012-02-13 14:44:29 PST
Comment on attachment 126839 [details] Patch Looks reasonable. Noel should double-check.
Eric Seidel (no email)
Comment 4 2012-02-13 14:49:46 PST
Comment on attachment 126839 [details] Patch I'd like to wait for his comment before landing. Would hate to land useless code. :)
noel gordon
Comment 5 2012-02-13 15:05:04 PST
Looks sane tome.
Adam Barth
Comment 6 2012-02-13 15:07:49 PST
Comment on attachment 126839 [details] Patch Thanks Noel.
noel gordon
Comment 7 2012-02-14 00:07:01 PST
np, and sane because the little-endian skia-using ports (chrome) use BGRA skia bitmaps, except chrome android where RGBA skia bitmaps are in vogue for some reason - see jpeg decoder fix bug 75861.
WebKit Review Bot
Comment 8 2012-02-14 00:16:53 PST
Comment on attachment 126839 [details] Patch Clearing flags on attachment: 126839 Committed r107679: <http://trac.webkit.org/changeset/107679>
WebKit Review Bot
Comment 9 2012-02-14 00:16:57 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.