|Summary:||Upstream Android's support for SK_B32_SHIFT to JPEGImageEncoder|
|Product:||WebKit||Reporter:||Eric Seidel (no email) <eric>|
|Component:||New Bugs||Assignee:||Eric Seidel (no email) <eric>|
|Severity:||Normal||CC:||abarth, noel.gordon, satish, webkit.review.bot|
|Version:||528+ (Nightly build)|
Description Eric Seidel (no email) 2012-02-13 14:39:38 PST
Comment 1 Eric Seidel (no email) 2012-02-13 14:40:18 PST
Created attachment 126839 [details] Patch
Comment 2 Eric Seidel (no email) 2012-02-13 14:41:17 PST
Someone with familiarity of Skia and the JPEGEncoder should look at this and make sure it's sane.
Comment 3 Adam Barth 2012-02-13 14:44:29 PST
Comment on attachment 126839 [details] Patch Looks reasonable. Noel should double-check.
Comment 4 Eric Seidel (no email) 2012-02-13 14:49:46 PST
Comment on attachment 126839 [details] Patch I'd like to wait for his comment before landing. Would hate to land useless code. :)
Comment 5 noel gordon 2012-02-13 15:05:04 PST
Looks sane tome.
Comment 6 Adam Barth 2012-02-13 15:07:49 PST
Comment on attachment 126839 [details] Patch Thanks Noel.
Comment 7 noel gordon 2012-02-14 00:07:01 PST
np, and sane because the little-endian skia-using ports (chrome) use BGRA skia bitmaps, except chrome android where RGBA skia bitmaps are in vogue for some reason - see jpeg decoder fix bug 75861.
Comment 8 WebKit Review Bot 2012-02-14 00:16:53 PST
Comment on attachment 126839 [details] Patch Clearing flags on attachment: 126839 Committed r107679: <http://trac.webkit.org/changeset/107679>
Comment 9 WebKit Review Bot 2012-02-14 00:16:57 PST
All reviewed patches have been landed. Closing bug.