Summary: | Last character display for passwords in Android. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ramya Chandrasekaran <cramya> | ||||||||
Component: | New Bugs | Assignee: | Ramya Chandrasekaran <cramya> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, fishd, tkent, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Ramya Chandrasekaran
2012-02-13 14:00:51 PST
Created attachment 126829 [details]
Patch
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API. Created attachment 126835 [details]
Patch
Comment on attachment 126835 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126835&action=review The rest of the change looks fine. > Source/WebCore/page/Settings.cpp:233 > +#if OS(ANDROID) > + , m_passwordEchoEnabled(true) > +#else > , m_passwordEchoEnabled(false) > +#endif This isn't correct. The Android should change this preference via the Chromium WebKit API. We use the same initializations across all the ports. Comment on attachment 126835 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126835&action=review > Source/WebCore/ChangeLog:9 > + No new tests. (OOPS!) > + This line should be removed or modified. > Tools/DumpRenderTree/chromium/WebPreferences.cpp:248 > +#if OS(ANDROID) > + // By default, this is set to true for ANDROID in Settings.cpp. > + // This should be false for LayoutTests. > + settings->setPasswordEchoEnabled(false); > +#endif #if and #endif are not needed. Comment on attachment 126835 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126835&action=review > Source/WebKit/chromium/public/WebSettings.h:135 > + virtual void setPasswordEchoEnabled(bool) = 0; API changes LGTM Created attachment 127035 [details]
Patch
Comment on attachment 127035 [details]
Patch
Looks great. Thanks!
Comment on attachment 127035 [details] Patch Clearing flags on attachment: 127035 Committed r107739: <http://trac.webkit.org/changeset/107739> All reviewed patches have been landed. Closing bug. |