Bug 78526

Summary: Convert RenderFrameSet to LayoutUnits in preparation for turning on subpixel layout
Product: WebKit Reporter: Emil A Eklund <eae>
Component: Layout and RenderingAssignee: Emil A Eklund <eae>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eric, leviw, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 63567    
Attachments:
Description Flags
Patch
none
Patch none

Description Emil A Eklund 2012-02-13 13:42:46 PST
Convert RenderFrameSet to use LayoutUnits internally.
Comment 1 Emil A Eklund 2012-02-13 14:14:05 PST
Created attachment 126834 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-02-15 13:15:00 PST
Comment on attachment 126834 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=126834&action=review

> Source/WebCore/rendering/RenderFrameSet.cpp:85
> +void RenderFrameSet::paintColumnBorder(const PaintInfo& paintInfo, const IntRect& borderRect)
>  {
> -    if (!paintInfo.rect.intersects(pixelSnappedIntRect(borderRect)))
> +    if (!paintInfo.rect.intersects(borderRect))

Why is this one ints?

> Source/WebCore/rendering/RenderFrameSet.cpp:103
>  void RenderFrameSet::paintRowBorder(const PaintInfo& paintInfo, const LayoutRect& borderRect)

Did you intentionally leave this one LayoutRects?

> Source/WebCore/rendering/RenderFrameSet.h:122
> +    void paintRowBorder(const PaintInfo&, const IntRect&);

This doesn't match the cpp side of your change.
Comment 3 Emil A Eklund 2012-02-15 16:10:23 PST
(In reply to comment #2)
> (From update of attachment 126834 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=126834&action=review
> 
> > Source/WebCore/rendering/RenderFrameSet.cpp:85
> > +void RenderFrameSet::paintColumnBorder(const PaintInfo& paintInfo, const IntRect& borderRect)
> >  {
> > -    if (!paintInfo.rect.intersects(pixelSnappedIntRect(borderRect)))
> > +    if (!paintInfo.rect.intersects(borderRect))
> 
> Why is this one ints?

paintInfo.rect is in device pixels and represents what will be painted. As such we are keeping it in ints.

> 
> > Source/WebCore/rendering/RenderFrameSet.cpp:103
> >  void RenderFrameSet::paintRowBorder(const PaintInfo& paintInfo, const LayoutRect& borderRect)
> 
> Did you intentionally leave this one LayoutRects?

No, my bad. The .h file is correct.

> 
> > Source/WebCore/rendering/RenderFrameSet.h:122
> > +    void paintRowBorder(const PaintInfo&, const IntRect&);
> 
> This doesn't match the cpp side of your change.

I'll fix the cpp side.
Comment 4 Emil A Eklund 2012-02-15 17:01:35 PST
Created attachment 127277 [details]
Patch
Comment 5 Eric Seidel (no email) 2012-02-15 17:13:10 PST
Comment on attachment 127277 [details]
Patch

OK.
Comment 6 Emil A Eklund 2012-02-15 17:18:02 PST
Thanks for catching the header/cpp mismatch, can't believe I missed that.
Comment 7 WebKit Review Bot 2012-02-15 23:04:32 PST
Comment on attachment 127277 [details]
Patch

Clearing flags on attachment: 127277

Committed r107889: <http://trac.webkit.org/changeset/107889>
Comment 8 WebKit Review Bot 2012-02-15 23:04:38 PST
All reviewed patches have been landed.  Closing bug.