Summary: | Convert RenderFrameSet to LayoutUnits in preparation for turning on subpixel layout | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Emil A Eklund <eae> | ||||||
Component: | Layout and Rendering | Assignee: | Emil A Eklund <eae> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | darin, eric, leviw, simon.fraser, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 63567 | ||||||||
Attachments: |
|
Description
Emil A Eklund
2012-02-13 13:42:46 PST
Created attachment 126834 [details]
Patch
Comment on attachment 126834 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126834&action=review > Source/WebCore/rendering/RenderFrameSet.cpp:85 > +void RenderFrameSet::paintColumnBorder(const PaintInfo& paintInfo, const IntRect& borderRect) > { > - if (!paintInfo.rect.intersects(pixelSnappedIntRect(borderRect))) > + if (!paintInfo.rect.intersects(borderRect)) Why is this one ints? > Source/WebCore/rendering/RenderFrameSet.cpp:103 > void RenderFrameSet::paintRowBorder(const PaintInfo& paintInfo, const LayoutRect& borderRect) Did you intentionally leave this one LayoutRects? > Source/WebCore/rendering/RenderFrameSet.h:122 > + void paintRowBorder(const PaintInfo&, const IntRect&); This doesn't match the cpp side of your change. (In reply to comment #2) > (From update of attachment 126834 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=126834&action=review > > > Source/WebCore/rendering/RenderFrameSet.cpp:85 > > +void RenderFrameSet::paintColumnBorder(const PaintInfo& paintInfo, const IntRect& borderRect) > > { > > - if (!paintInfo.rect.intersects(pixelSnappedIntRect(borderRect))) > > + if (!paintInfo.rect.intersects(borderRect)) > > Why is this one ints? paintInfo.rect is in device pixels and represents what will be painted. As such we are keeping it in ints. > > > Source/WebCore/rendering/RenderFrameSet.cpp:103 > > void RenderFrameSet::paintRowBorder(const PaintInfo& paintInfo, const LayoutRect& borderRect) > > Did you intentionally leave this one LayoutRects? No, my bad. The .h file is correct. > > > Source/WebCore/rendering/RenderFrameSet.h:122 > > + void paintRowBorder(const PaintInfo&, const IntRect&); > > This doesn't match the cpp side of your change. I'll fix the cpp side. Created attachment 127277 [details]
Patch
Comment on attachment 127277 [details]
Patch
OK.
Thanks for catching the header/cpp mismatch, can't believe I missed that. Comment on attachment 127277 [details] Patch Clearing flags on attachment: 127277 Committed r107889: <http://trac.webkit.org/changeset/107889> All reviewed patches have been landed. Closing bug. |