Bug 78520

Summary:

Cleanup PageCache::canCachePageContainingThisFrame readability

Product:

WebKit

Reporter:

Brady Eidson <beidson>

Component:

Page Loading

Assignee:

Brady Eidson <beidson>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch v1	andersca: review+

Brady Eidson

Reported 2012-02-13 13:00:02 PST

Cleanup PageCache::canCachePageContainingThisFrame It's a giant if statement that keeps accessing the same member variables through getters. Over and over. And over. Just store them locally to make it more readable.

Attachments
Patch v1 (3.64 KB, patch) 2012-02-13 13:02 PST, Brady Eidson	andersca: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Brady Eidson

Comment 1 2012-02-13 13:02:52 PST

Created attachment 126810 [details] Patch v1

Brady Eidson

Comment 2 2012-02-13 13:09:07 PST

http://trac.webkit.org/changeset/107596

Note You need to log in before you can comment on or make changes to this bug.