Bug 78520

Summary: Cleanup PageCache::canCachePageContainingThisFrame readability
Product: WebKit Reporter: Brady Eidson <beidson>
Component: Page LoadingAssignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch v1 andersca: review+

Description Brady Eidson 2012-02-13 13:00:02 PST
Cleanup PageCache::canCachePageContainingThisFrame

It's a giant if statement that keeps accessing the same member variables through getters.  Over and over.  And over.

Just store them locally to make it more readable.
Comment 1 Brady Eidson 2012-02-13 13:02:52 PST
Created attachment 126810 [details]
Patch v1
Comment 2 Brady Eidson 2012-02-13 13:09:07 PST
http://trac.webkit.org/changeset/107596