Bug 78519
| Summary: | RenderTable::addChild() wrapInAnonymousSection is never !child->isPositioned() | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Robert Hogan <robert> |
| Component: | Tables | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | ahmad.saleem792, ap, arpitabahuguna, bfulgham, jchaffraix, pravind.2k4, simon.fraser, zalan |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
Robert Hogan
void RenderTable::addChild(RenderObject* child, RenderObject* beforeChild)
{
// Make sure we don't append things after :after-generated content if we have it.
if (!beforeChild)
beforeChild = afterPseudoElementRenderer();
bool wrapInAnonymousSection = !child->isPositioned();
What was this initialization once for I wonder? The subsequent code means this initial value is not used anymore.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Julien Chaffraix
I wonder too, CSS 2.1 (section 17.2.1) doesn't special case the 'generate missing child wrappers' for out-of-flow elements.
It seems we didn't wrap out-of-flow elements at some point but this regressed. See bug 11363.
Ahmad Saleem
This code has been removed with this commit:
https://github.com/WebKit/WebKit/commit/69dba55f3051498c5717f2497b6b379cfdc02f05
Is this needed? Thanks!