Bug 78500

Summary:

Web Inspector: fire stylesheet changed event upon CSS modifications.

Product:

WebKit

Reporter:

Pavel Feldman <pfeldman>

Component:

Web Inspector (Deprecated)

Assignee:

Pavel Feldman <pfeldman>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	yurys: review+

Description Pavel Feldman 2012-02-13 08:27:21 PST

This is needed for syncing undo with the revision history.

Comment 1 Pavel Feldman 2012-02-13 08:28:52 PST

Created attachment 126776 [details]
Patch

Comment 2 Yury Semikhatsky 2012-02-13 09:07:05 PST

Comment on attachment 126776 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=126776&action=review

> Source/WebCore/inspector/InspectorStyleSheet.h:160
> +    struct Listener {

Should be class.

> Source/WebCore/inspector/front-end/CSSStyleModel.js:291
> +        this._pendingCommands.push(["CSSAgent.setStyleSheetText", majorChange]);

The name doesn't seem to be used, otherwise please introduce a class for the commands.

> LayoutTests/inspector/styles/styles-history.html:40
> +                    next();                

Remove the spaces.

Comment 3 Pavel Feldman 2012-02-14 00:50:32 PST

Committed r107683: <http://trac.webkit.org/changeset/107683>