Bug 78483

Summary:

HTMLMarqueeElement: Don't cache presence of truespeed attribute.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

DOM

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, koivisto

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patçh	koivisto: review+

Andreas Kling

Reported 2012-02-13 04:03:36 PST

We can look it up in minimumDelay() instead and lose the parseAttribute() overload.

Attachments
Patçh (3.87 KB, patch) 2012-02-13 04:40 PST, Andreas Kling	koivisto: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Andreas Kling

Comment 1 2012-02-13 04:40:05 PST

Antti Koivisto

Comment 2 2012-02-13 09:28:16 PST

Comment on attachment 126753 [details] Patçh stuff that matters indeed!

Andreas Kling

Comment 3 2012-02-13 09:38:05 PST

Darin Adler

Comment 4 2012-02-13 17:39:47 PST

Comment on attachment 126753 [details] Patçh View in context: https://bugs.webkit.org/attachment.cgi?id=126753&action=review > Source/WebCore/html/HTMLMarqueeElement.cpp:-39 > -const int defaultMinimumDelay = 60; Was it really an improvement to remove the named constant?

Andreas Kling

Comment 5 2012-02-14 05:30:25 PST

(In reply to comment #4) > (From update of attachment 126753 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=126753&action=review > > > Source/WebCore/html/HTMLMarqueeElement.cpp:-39 > > -const int defaultMinimumDelay = 60; > > Was it really an improvement to remove the named constant? In retrospect maybe not. I'll put it back if you like.

Note You need to log in before you can comment on or make changes to this bug.