Bug 78483 - HTMLMarqueeElement: Don't cache presence of truespeed attribute.
Summary: HTMLMarqueeElement: Don't cache presence of truespeed attribute.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-13 04:03 PST by Andreas Kling
Modified: 2012-02-14 05:30 PST (History)
2 users (show)

See Also:

Attachments
Patçh (3.87 KB, patch)
2012-02-13 04:40 PST, Andreas Kling 		koivisto: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2012-02-13 04:03:36 PST 
We can look it up in minimumDelay() instead and lose the parseAttribute() overload.
Comment 1 Andreas Kling 2012-02-13 04:40:05 PST 
Created attachment 126753 [details]
Patçh
Comment 2 Antti Koivisto 2012-02-13 09:28:16 PST 
Comment on attachment 126753 [details]
Patçh

stuff that matters indeed!
Comment 3 Andreas Kling 2012-02-13 09:38:05 PST 
Committed r107579: <http://trac.webkit.org/changeset/107579>
Comment 4 Darin Adler 2012-02-13 17:39:47 PST 
Comment on attachment 126753 [details]
Patçh

View in context: https://bugs.webkit.org/attachment.cgi?id=126753&action=review

> Source/WebCore/html/HTMLMarqueeElement.cpp:-39
> -const int defaultMinimumDelay = 60;

Was it really an improvement to remove the named constant?
Comment 5 Andreas Kling 2012-02-14 05:30:25 PST 
(In reply to comment #4)
> (From update of attachment 126753 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=126753&action=review
> 
> > Source/WebCore/html/HTMLMarqueeElement.cpp:-39
> > -const int defaultMinimumDelay = 60;
> 
> Was it really an improvement to remove the named constant?

In retrospect maybe not. I'll put it back if you like.