Bug 78457

Summary: Move ENABLE(GAMEPAD) logic out of Navigator.h/cpp
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, morrita, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
work in progress
none
work in progress
none
Patch
none
Patch morrita: review+, abarth: commit-queue+

Adam Barth
Reported 2012-02-12 22:00:16 PST
Move ENABLE(GAMEPAD) logic out of Navigator.h/cpp
Attachments
work in progress (8.14 KB, patch)
2012-02-12 22:00 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
work in progress (12.41 KB, patch)
2012-02-12 22:02 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (14.70 KB, patch)
2012-02-12 22:19 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (19.08 KB, patch)
2012-02-12 22:27 PST, Adam Barth 		morrita: review+
abarth: commit-queue+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-02-12 22:00:54 PST
Created attachment 126713 [details] work in progress
Adam Barth
Comment 2 2012-02-12 22:02:30 PST
Created attachment 126714 [details] work in progress
Adam Barth
Comment 3 2012-02-12 22:19:02 PST
Created attachment 126716 [details] Patch
Hajime Morrita
Comment 4 2012-02-12 22:23:35 PST
Comment on attachment 126716 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126716&action=review Basically looks good. And thanks for cleaning up PageSupplement. > Source/WebCore/ChangeLog:19 > + * WebCore.gypi: Don't miss WebCore.xcodeproj/project.pbxproj.
Adam Barth
Comment 5 2012-02-12 22:27:59 PST
Created attachment 126718 [details] Patch
Adam Barth
Comment 6 2012-02-12 23:03:22 PST
Committed r107536: <http://trac.webkit.org/changeset/107536>
Note You need to log in before you can comment on or make changes to this bug.