Bug 78457

Summary:

Move ENABLE(GAMEPAD) logic out of Navigator.h/cpp

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

New Bugs

Assignee:

Adam Barth <abarth>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric, morrita, rakuco, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
work in progress	none
work in progress	none
Patch	none
Patch	morrita: review+, abarth: commit-queue+

Description Adam Barth 2012-02-12 22:00:16 PST

Move ENABLE(GAMEPAD) logic out of Navigator.h/cpp

Comment 1 Adam Barth 2012-02-12 22:00:54 PST

Created attachment 126713 [details]
work in progress

Comment 2 Adam Barth 2012-02-12 22:02:30 PST

Created attachment 126714 [details]
work in progress

Comment 3 Adam Barth 2012-02-12 22:19:02 PST

Created attachment 126716 [details]
Patch

Comment 4 Hajime Morrita 2012-02-12 22:23:35 PST

Comment on attachment 126716 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=126716&action=review

Basically looks good. And thanks for cleaning up PageSupplement.

> Source/WebCore/ChangeLog:19
> +        * WebCore.gypi:

Don't miss WebCore.xcodeproj/project.pbxproj.

Comment 5 Adam Barth 2012-02-12 22:27:59 PST

Created attachment 126718 [details]
Patch

Comment 6 Adam Barth 2012-02-12 23:03:22 PST

Committed r107536: <http://trac.webkit.org/changeset/107536>