Summary: | Add a [V8CustomToJSObject] IDL attribute | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kentaro Hara <haraken> | ||||
Component: | WebCore JavaScript | Assignee: | Kentaro Hara <haraken> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, darin, japhet, macpherson, menard, ojan, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 77393 | ||||||
Attachments: |
|
Description
Kentaro Hara
2012-02-12 18:24:55 PST
Maybe we should just call it V8CustomToJS ? It's not 100% accurate, but the shorter name seems better and avoids having to renaming the JSC version. Maybe CustomToVM ? Dunno... My rating is as follows:-) - [V8CustomToJSObject] : 1.0 (Naming consistency with [CustomToNativeObject]) - [V8CustomToJS] : 0.8 (It might be confusing in V8, since it actually means [CustomToV8]) - [V8CustomToWrappedObject] : 0.6 ([*WrappedObject] would be unclearer than [*JSObject]) - [CustomToVM] : 0.4 (Not so descriptive) WDTY? V8CustomToJSObject sounds fine. Created attachment 126706 [details]
Patch
Comment on attachment 126706 [details] Patch Clearing flags on attachment: 126706 Committed r107530: <http://trac.webkit.org/changeset/107530> All reviewed patches have been landed. Closing bug. |