Bug 78425

Summary: Implement more ScrollElasticityControllerClient member functions
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 128258    
Attachments:
Description Flags
Patch sam: review+

Anders Carlsson
Reported 2012-02-11 14:56:12 PST
Implement more ScrollElasticityControllerClient member functions
Attachments
Patch (9.25 KB, patch)
2012-02-11 14:57 PST, Anders Carlsson 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2012-02-11 14:57:22 PST
Created attachment 126650 [details] Patch
Anders Carlsson
Comment 2 2012-02-11 15:05:00 PST
Committed r107488: <http://trac.webkit.org/changeset/107488>
Brent Fulgham
Comment 3 2014-02-05 09:51:07 PST
Comment on attachment 126650 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126650&action=review > Source/WebCore/page/scrolling/mac/ScrollingTreeNodeMac.mm:134 > + limitDelta.setHeight(scrollPosition().x() - minimumScrollPosition().x()); Should this really have been setHeight? It seems like other cases of this logic would use "setWidth". I don't think it changes anything, but might be clearer.
Note You need to log in before you can comment on or make changes to this bug.