Bug 78425 - Implement more ScrollElasticityControllerClient member functions
Summary: Implement more ScrollElasticityControllerClient member functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks: 128258
  Show dependency treegraph
 
Reported: 2012-02-11 14:56 PST by Anders Carlsson
Modified: 2014-02-05 10:31 PST (History)
0 users

See Also:


Attachments
Patch (9.25 KB, patch)
2012-02-11 14:57 PST, Anders Carlsson
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2012-02-11 14:56:12 PST
Implement more ScrollElasticityControllerClient member functions
Comment 1 Anders Carlsson 2012-02-11 14:57:22 PST
Created attachment 126650 [details]
Patch
Comment 2 Anders Carlsson 2012-02-11 15:05:00 PST
Committed r107488: <http://trac.webkit.org/changeset/107488>
Comment 3 Brent Fulgham 2014-02-05 09:51:07 PST
Comment on attachment 126650 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=126650&action=review

> Source/WebCore/page/scrolling/mac/ScrollingTreeNodeMac.mm:134
> +            limitDelta.setHeight(scrollPosition().x() - minimumScrollPosition().x());

Should this really have been setHeight? It seems like other cases of this logic would use "setWidth".

I don't think it changes anything, but might be clearer.